Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

fix(labs): Cleanup small issues with lab section #2010

Merged
merged 31 commits into from
Apr 24, 2020

Conversation

alti21
Copy link
Contributor

@alti21 alti21 commented Apr 23, 2020

Fixes #1973 .

Changes proposed in this pull request:

Fixed some bugs:

  • On the new lab screen, the patient typeahead label is not showing the internationalization key anymore
  • On the new lab screen and the view lab screen, the notes field is now marked as required

Note: pull requests without proper descriptions may simply be closed without further discussion. We appreciate your contributions, but need to know what you are offering in clearly described format. Provide tests for all code that you add/modify. If you add/modify any components update the storybook. Thanks! (you can delete this text)

@vercel
Copy link

vercel bot commented Apr 23, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/psu0d650v
✅ Preview: https://hospitalrun-frontend-git-fork-alti21-master.hospitalrun.now.sh

@jackcmeyer jackcmeyer added labs issue/pull request that interacts with labs module 🐛bug issue/pull request that documents/fixes a bug labels Apr 24, 2020
@jackcmeyer jackcmeyer added this to the v2.0 milestone Apr 24, 2020
@jackcmeyer
Copy link
Member

Code looks good. Just need to fix linter issues.

Copy link
Member

@fox1t fox1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after fixing linter issues.

@vercel vercel bot temporarily deployed to Preview April 24, 2020 16:38 Inactive
@alti21
Copy link
Contributor Author

alti21 commented Apr 24, 2020

@jackcmeyer I had the same linter issues for my previous pull request, I'm not sure how to fix them. Running yarn lint:fix doesn't solve the issues.

@gitpod-io
Copy link

gitpod-io bot commented Apr 24, 2020

@vercel vercel bot temporarily deployed to Preview April 24, 2020 16:55 Inactive
@jackcmeyer jackcmeyer merged commit e445a97 into HospitalRun:master Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛bug issue/pull request that documents/fixes a bug labs issue/pull request that interacts with labs module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup small issues with lab section
3 participants