feat(viewpatient): added labs tab to ViewPatient #1987

rubencgt · 2020-04-14T22:13:50Z

A patient can see all his requests for labs in the Labs tab

fix #1972

vercel · 2020-04-14T22:13:57Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/bcb6xwod2
✅ Preview: https://hospitalrun-frontend-git-fork-rubencgt-feature-labstab.hospitalrun.now.sh

jackcmeyer

@rubencgt let me know if you need any help getting the feedback addressed!

src/clients/db/LabRepository.ts

jackcmeyer · 2020-04-17T05:09:35Z

src/patients/labs/Labs.tsx

@@ -0,0 +1,63 @@
+import React, { useEffect } from 'react'


Need tests for this component:

test that the table renders with the correct labs

test that the content of the table is correct

test that when no labs are returned, the warning message appears

jackcmeyer · 2020-04-17T05:11:55Z

src/labs/labs-slice.ts

+
+interface LabsState {
+  isLoading: boolean
+  labs: Lab[]


I think that this should be added as part of the patient slice. It seems like this functionality is part of the patient module, so therefore it makes sense to have the patient slice own this state update. @fox1t any thoughts here?

I imagine the patient slice getting a new state field called labs, and then a thunk function called findLabsPatientId and the corresponding reducers.

jackcmeyer · 2020-04-17T05:15:25Z

src/labs/labs-slice.ts

@@ -0,0 +1,42 @@
+import { createSlice, PayloadAction } from '@reduxjs/toolkit'


Need to add tests for this functionality. Of course the test implementation might change a little if we move it to the patient slice, however, the test concepts shouldn't.

test for the fetchPatientLabs thunk dispatching fetchLabsStart

test that it calls the LabRepository correctly

test that it dispatches fetchLabsSuccesss with the correct data

test that the fetchLabsStart reducer update updates the is loading state correctly

test that the fetchLabsSuccess reducer updates the labs list and loading state correctly

jackcmeyer · 2020-04-17T05:15:52Z

src/clients/db/LabRepository.ts

@@ -6,6 +6,18 @@ export class LabRepository extends Repository<Lab> {
  constructor() {
    super(labs)
  }
+
+  async searchPatientLabs(patientId: string): Promise<Lab[]> {


Need to add tests to show that this is working correctly.

jackcmeyer · 2020-05-02T21:29:55Z

@rubencgt the MacOS build is failing. I'm guessing due to a missing mock somewhere. Let me know if you need help resolving it.

A patient can see all his requests for labs in the Labs tab fix HospitalRun#1972

…abs_tab

rubencgt · 2020-05-03T09:24:32Z

@jackcmeyer for some reason I can't reproduce the issue locally (I use MacOS 10.15.4),
but I added the mock in the test where it seemed to be it was missing, NewAppointment.test.tsx.

jackcmeyer · 2020-05-03T16:39:34Z

@jackcmeyer for some reason I can't reproduce the issue locally (I use MacOS 10.15.4),
but I added the mock in the test where it seemed to be it was missing, NewAppointment.test.tsx.

I was able to reproduce (I also use a Mac). I'll investigate a fix.

vercel bot deployed to Preview April 14, 2020 22:13 View deployment

vercel bot deployed to Preview April 15, 2020 13:45 View deployment

vercel bot deployed to Preview April 16, 2020 06:08 View deployment

vercel bot requested a deployment to Preview April 16, 2020 15:08 Abandoned

matteovivona requested review from jackcmeyer and fox1t and removed request for jackcmeyer April 16, 2020 17:43

vercel bot deployed to Preview April 16, 2020 18:34 View deployment

jackcmeyer suggested changes Apr 17, 2020

View reviewed changes

vercel bot deployed to Preview April 17, 2020 07:37 View deployment

rubencgt changed the title ~~feat(viewpatient): added labs tab to ViewPatient~~ WIP feat(viewpatient): added labs tab to ViewPatient Apr 17, 2020

rubencgt changed the title ~~WIP feat(viewpatient): added labs tab to ViewPatient~~ WIP: feat(viewpatient): added labs tab to ViewPatient Apr 17, 2020

vercel bot deployed to Preview April 17, 2020 12:18 View deployment

vercel bot deployed to Preview April 19, 2020 06:24 View deployment

vercel bot deployed to Preview April 21, 2020 19:50 View deployment

rubencgt changed the title ~~WIP: feat(viewpatient): added labs tab to ViewPatient~~ feat(viewpatient): added labs tab to ViewPatient Apr 21, 2020

rubencgt force-pushed the feature/labs_tab branch from f74874c to 7bca96e Compare April 21, 2020 22:01

vercel bot deployed to Preview April 21, 2020 22:01 View deployment

vercel bot deployed to Preview April 21, 2020 23:01 View deployment

vercel bot deployed to Preview April 22, 2020 10:15 View deployment

vercel bot deployed to Preview April 22, 2020 11:09 View deployment

vercel bot deployed to Preview April 22, 2020 11:41 View deployment

vercel bot deployed to Preview April 22, 2020 12:08 View deployment

vercel bot deployed to Preview April 22, 2020 12:49 View deployment

matteovivona added this to the v2.0 milestone Apr 24, 2020

rubencgt force-pushed the feature/labs_tab branch from 08709bf to 69eb7a1 Compare April 25, 2020 17:54

vercel bot deployed to Preview April 25, 2020 17:54 View deployment

rubencgt requested a review from jackcmeyer April 25, 2020 17:56

vercel bot deployed to Preview May 2, 2020 12:58 View deployment

Merge branch 'master' into feature/labs_tab

6af0f29

vercel bot temporarily deployed to Preview May 2, 2020 13:09 Inactive

Merge branch 'master' into feature/labs_tab

dbbd6a7

vercel bot deployed to Preview May 2, 2020 13:12 View deployment

Merge branch 'master' into feature/labs_tab

81dc05f

vercel bot deployed to Preview May 2, 2020 13:45 View deployment

jackcmeyer added patients issue/pull request that interacts with patients module 🚀enhancement an issue/pull request that adds a feature to the application labels May 2, 2020

jackcmeyer added this to In progress in Version 2.0 via automation May 2, 2020

matteovivona added the in progress indicates that issue/pull request is currently being worked on label May 3, 2020

Merge branch 'master' into feature/labs_tab

0fa5639

vercel bot deployed to Preview May 3, 2020 08:41 View deployment

rubencgt added 2 commits May 3, 2020 11:20

feat(viewpatient): added labs tab to ViewPatient

c9bcd47

A patient can see all his requests for labs in the Labs tab fix HospitalRun#1972

Merge remote-tracking branch 'origin/feature/labs_tab' into feature/l…

652f11d

…abs_tab

vercel bot deployed to Preview May 3, 2020 09:22 View deployment

feat(patients): fix failing test due to missing mocks

6ac824e

vercel bot deployed to Preview May 3, 2020 16:58 View deployment

jackcmeyer previously approved these changes May 3, 2020

View reviewed changes

feat(patients): removes some file

afca198

jackcmeyer dismissed their stale review via afca198 May 3, 2020 17:20

vercel bot deployed to Preview May 3, 2020 17:20 View deployment

jackcmeyer approved these changes May 3, 2020

View reviewed changes

Merge branch 'master' into feature/labs_tab

9d5a6e5

vercel bot deployed to Preview May 3, 2020 17:42 View deployment

jackcmeyer merged commit 4a1c7ed into HospitalRun:master May 3, 2020

Version 2.0 automation moved this from In progress to Done May 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(viewpatient): added labs tab to ViewPatient #1987

feat(viewpatient): added labs tab to ViewPatient #1987

rubencgt commented Apr 14, 2020 •

edited

Loading

vercel bot commented Apr 14, 2020 •

edited

Loading

jackcmeyer left a comment

jackcmeyer Apr 17, 2020 •

edited

Loading

jackcmeyer Apr 17, 2020

jackcmeyer Apr 17, 2020 •

edited

Loading

jackcmeyer Apr 17, 2020

jackcmeyer commented May 2, 2020

rubencgt commented May 3, 2020 •

edited

Loading

jackcmeyer commented May 3, 2020

		@@ -0,0 +1,42 @@
		import { createSlice, PayloadAction } from '@reduxjs/toolkit'

feat(viewpatient): added labs tab to ViewPatient #1987

feat(viewpatient): added labs tab to ViewPatient #1987

Conversation

rubencgt commented Apr 14, 2020 • edited Loading

vercel bot commented Apr 14, 2020 • edited Loading

jackcmeyer left a comment

Choose a reason for hiding this comment

jackcmeyer Apr 17, 2020 • edited Loading

Choose a reason for hiding this comment

jackcmeyer Apr 17, 2020

Choose a reason for hiding this comment

jackcmeyer Apr 17, 2020 • edited Loading

Choose a reason for hiding this comment

jackcmeyer Apr 17, 2020

Choose a reason for hiding this comment

jackcmeyer commented May 2, 2020

rubencgt commented May 3, 2020 • edited Loading

jackcmeyer commented May 3, 2020

rubencgt commented Apr 14, 2020 •

edited

Loading

vercel bot commented Apr 14, 2020 •

edited

Loading

jackcmeyer Apr 17, 2020 •

edited

Loading

jackcmeyer Apr 17, 2020 •

edited

Loading

rubencgt commented May 3, 2020 •

edited

Loading