Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

fix(patients): current patient can no longer be related person #1959

Merged
merged 23 commits into from
Apr 11, 2020

Conversation

alti21
Copy link
Contributor

@alti21 alti21 commented Apr 2, 2020

Fixes #1946.

Changes proposed in this pull request:

  • Current patient cannot show up in related person search

@vercel
Copy link

vercel bot commented Apr 2, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/hospitalrun/hospitalrun-frontend/9cacf97gl
✅ Preview: https://hospitalrun-frontend-git-fork-alti21-master.hospitalrun.now.sh

Copy link
Member

@jackcmeyer jackcmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alti21, thanks for the contribution!

Just a few changes requested:

  • minor code tweaks
  • fix lint issues
  • add tests

src/patients/related-persons/AddRelatedPersonModal.tsx Outdated Show resolved Hide resolved
src/patients/related-persons/AddRelatedPersonModal.tsx Outdated Show resolved Hide resolved
src/patients/related-persons/AddRelatedPersonModal.tsx Outdated Show resolved Hide resolved
@jackcmeyer jackcmeyer self-requested a review April 3, 2020 02:05
Copy link
Member

@jackcmeyer jackcmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alti21, thanks for the contribution!

Just a few changes requested:
-[ ] minor code tweaks
-[ ] fix lint issues
-[ ] add tests

@jackcmeyer
Copy link
Member

@alti21 I was able to fix the lint errors from master, so no need to worry about those.

@jackcmeyer jackcmeyer changed the title fix(#1946): patients can also be related person fix(patients): patients can also be related person Apr 3, 2020
@jackcmeyer jackcmeyer changed the title fix(patients): patients can also be related person fix(patients): current patient can no longer be related person Apr 3, 2020
@matteovivona matteovivona added the in progress indicates that issue/pull request is currently being worked on label Apr 8, 2020
@vercel vercel bot temporarily deployed to Preview April 10, 2020 22:33 Inactive
@vercel vercel bot temporarily deployed to Preview April 10, 2020 22:34 Inactive
@jackcmeyer jackcmeyer merged commit b816ebf into HospitalRun:master Apr 11, 2020
@jackcmeyer
Copy link
Member

Thanks for the contribution @alti21!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in progress indicates that issue/pull request is currently being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patient can also be related person
3 participants