Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

feat(patients): added an asterisk to the Allergy Name field #1944

Merged
merged 3 commits into from
Mar 24, 2020
Merged

feat(patients): added an asterisk to the Allergy Name field #1944

merged 3 commits into from
Mar 24, 2020

Conversation

mamoses
Copy link
Contributor

@mamoses mamoses commented Mar 24, 2020 •
edited by matteovivona
Loading

Fixes #1928

Changes proposed in this pull request:

  • Added an asterisk to indicate that the name field is required

@mamoses
style(component): added an asterisk to the Allergy Name field
7ff79d7 
Added an asterisk to indicate that the name field is required

#1928
@jsf-clabot
Copy link

jsf-clabot commented Mar 24, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@vercel
Copy link

vercel bot commented Mar 24, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/hospitalrun/hospitalrun-frontend/48mh64ze3
✅ Preview: https://hospitalrun-frontend-git-fork-mamoses-allergymodal.hospitalrun.now.sh

@matteovivona matteovivona requested a review from jackcmeyer March 24, 2020 21:23
jackcmeyer
jackcmeyer suggested changes Mar 24, 2020
View reviewed changes
.env.example Outdated
REACT_APP_HOSPITALRUN_API=http://0.0.0.0:5984
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to change the port? 5984 is usually what pouchdb runs on. We want to point to our server (which proxies to pouchdb).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the connecting to the server section I misunderstood step 4. Change the REACT_APP_HOSPITALRUN_API variable to point to the HospitalRun Development Server and had trouble running it. I got it working but forgot to switch it back sorry about that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries :)could you switch it back? Then we can merge this PR!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it back, let me know if there is any other changes that need to be made! Thanks!

@jackcmeyer jackcmeyer added the 🚀enhancement an issue/pull request that adds a feature to the application label Mar 24, 2020
@jackcmeyer jackcmeyer changed the title style(component): added an asterisk to the Allergy Name field feat(patients): added an asterisk to the Allergy Name field Mar 24, 2020
@jackcmeyer jackcmeyer added the patients issue/pull request that interacts with patients module label Mar 24, 2020
@jackcmeyer jackcmeyer added this to the v2.0 milestone Mar 24, 2020
@jackcmeyer jackcmeyer merged commit b7e7142 into HospitalRun:master Mar 24, 2020
@mamoses mamoses deleted the AllergyModal branch March 25, 2020 18:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackcmeyer jackcmeyer jackcmeyer approved these changes

Assignees
No one assigned
Labels
🚀enhancement an issue/pull request that adds a feature to the application patients issue/pull request that interacts with patients module
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

New Allergy Modal should mark required fields
3 participants
@mamoses @jsf-clabot @jackcmeyer