Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Breadcrumb for edit appointment is not correct #1854

Closed
jackcmeyer opened this issue Feb 25, 2020 · 5 comments · Fixed by #1863
Closed

Breadcrumb for edit appointment is not correct #1854

jackcmeyer opened this issue Feb 25, 2020 · 5 comments · Fixed by #1863
Labels
🐛bug issue/pull request that documents/fixes a bug good first issue indicates an issue is good for a first time contributor help wanted indicates that an issue is open for contributions scheduling issue/pull request that interacts with scheduling module
Milestone

Comments

@jackcmeyer
Copy link
Member

The breadcrumb for edit appointment shows Patient, which is not correct

🐛 Bug Report

When editing an appointment, the breadcrumb shows Patient

To Reproduce

  1. Create new appointment
  2. Click on appointment in calendar
  3. Click on edit button
  4. View incorrect breadcrumb

image

Expected behavior

Breadcrumb should show: Dashboard/Appointments/Appoint Start Date - Appointment Edit Date/Edit Appointment

Your Environment

  • node version: 10,12,13
  • os: Mac, Windows, Linux
  • any other relevant information
@jackcmeyer jackcmeyer added 🐛bug issue/pull request that documents/fixes a bug help wanted indicates that an issue is open for contributions scheduling issue/pull request that interacts with scheduling module labels Feb 25, 2020
@jackcmeyer jackcmeyer added this to the v2.0.0 milestone Feb 25, 2020
@jackcmeyer jackcmeyer added the good first issue indicates an issue is good for a first time contributor label Feb 25, 2020
@patrick-salvatore
Copy link

Hello, I'd like to help out with this bug.

@matteovivona
Copy link
Contributor

Hi, @patrick-salvatore. Thanks for your interest. Issuer assigned to you!

@oliv37
Copy link
Contributor

oliv37 commented Feb 26, 2020

When editing an appointment, the breadcrumb shows Patient

This assumption is wrong, the breadcrumb doesn't show at all (because the hook useAddBreadcrumb is not called into this view).

You see see Patient because it is the label of the first field, this label is not related to the breadcrumb

@jackcmeyer
Copy link
Member Author

jackcmeyer commented Feb 27, 2020

When editing an appointment, the breadcrumb shows Patient

This assumption is wrong, the breadcrumb doesn't show at all (because the hook useAddBreadcrumb is not called into this view).

You see see Patient because it is the label of the first field, this label is not related to the breadcrumb

Thanks for the extra information @oliv37 😊.

@matteovivona
Copy link
Contributor

@patrick-salvatore, the original contributor who made the breadcrumbs has already fixed the bug. Thank you for your availability!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛bug issue/pull request that documents/fixes a bug good first issue indicates an issue is good for a first time contributor help wanted indicates that an issue is open for contributions scheduling issue/pull request that interacts with scheduling module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants