This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
feat(dropdown): add dropdown component #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add dropdown component, initial structure, test, documentation and story fix #58
jackcmeyer
suggested changes
Dec 19, 2019
Remove default id prop, change ColorVariants constant variable to PascalCase, remove href from dropdown item and fix documentation fix #154
jackcmeyer
suggested changes
Dec 19, 2019
…uno/components into feat/add-dropdown-component
|
Hi @ocBruno. As I said in past, every contribution to the project is equally important. There is no problem for us to guide you, or everyone else, in the process of making a PR land to master, even if it could be a long process. I encourage you to continue making contributions and, indeed, I would like to know from you how we can improve the on-baording process! |
jackcmeyer
pushed a commit
that referenced
this pull request
Dec 31, 2019
jackcmeyer
pushed a commit
that referenced
this pull request
Dec 31, 2019
|
that request was by mistake apologies! |
jackcmeyer
approved these changes
Jan 1, 2020
fox1t
approved these changes
Jan 2, 2020
ghost
pushed a commit
that referenced
this pull request
Jan 2, 2020
# [0.26.0](v0.25.0...v0.26.0) (2020-01-02) ### Bug Fixes * **dropdown:** fix dropdown bugs ([3290a6a](3290a6a)), closes [#154](#154) * **dropdown:** fix missing necessary undefined type in id property ([35c04e4](35c04e4)), closes [#154](#154) * **dropdown:** make id optional on dropdown toggle and items ([787beb7](787beb7)), closes [#154](#154) * **eslint:** fix eslint rules for newer versions ([ddfb996](ddfb996)) ### Features * **dropdown:** add dropdown component ([304666f](304666f)), closes [#58](#58) * **dropdown:** randomly generate id if one is not given ([b5fb940](b5fb940))
|
🎉 This PR is included in version 0.26.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dropdown component, initial structure, test, documentation and story.
Fixes #58
Changes proposed in this pull request:
I realized I rushed into these issues and branches and might be cluttering the project so I decided to take a break and do some necessary studying before contributing to the project. I decided to put this last one up just in case it helps out someone in the future who takes on this issue. Feel free to close this and any other pull requests that aren't up to standard!