fix(lint): lints some files, adds new rules

.eslintrc.js

@@ -31,22 +31,23 @@ module.exports = {
   },
   plugins: ['react', '@typescript-eslint', 'prettier', 'jest'],
   rules: {
+    '@typescript-eslint/member-delimiter-style': 'off',
+    '@typescript-eslint/explicit-function-return-type': 'off',
+    '@typescript-eslint/no-explicit-any': 'off',
+    '@typescript-eslint/no-unused-vars': 'off',
+    '@typescript-eslint/unified-signatures': 'error',
+    '@typescript-eslint/no-inferrable-types': ['error', { ignoreParameters: true }],
     'react/jsx-filename-extension': ['error', { extensions: ['.tsx'] }],
-    // 'prettier/prettier': 'error',
-    'arrow-body-style': ['warn', 'as-needed'],
     'react/jsx-one-expression-per-line': 'off',
     'react/jsx-wrap-multilines': 'off',
+    'react/jsx-props-no-spreading': 'off',
+    'arrow-body-style': ['warn', 'as-needed'],
     'no-param-reassign': ['error', { props: false }],
     'import/prefer-default-export': 'off',
-    '@typescript-eslint/member-delimiter-style': 'off',
-    '@typescript-eslint/explicit-function-return-type': 'off',
-    '@typescript-eslint/no-explicit-any': 'off',
-    '@typescript-eslint/no-unused-vars': 'off',
-    curly: ['error', 'all'],
     'no-console': 'off',
     'eol-last': ['error', 'always'],
     'no-debugger': 'error',
-    '@typescript-eslint/unified-signatures': 'error',
-    '@typescript-eslint/no-inferrable-types': ['error', { ignoreParameters: true }],
+    'no-nested-ternary': 'off',
+    curly: ['error', 'all'],
   },
 }

src/components/Modal/Modal.tsx

@@ -4,40 +4,40 @@ import { Button, Props as ButtonProps } from '../Button'
 import { ButtonsAlignment } from './interfaces'
 
 interface Props {
-  /** Defines if the modal should be visible.*/
+  /** Defines if the modal should be visible. */
   show: boolean
-  /** Toggles the modal visibility.*/
+  /** Toggles the modal visibility. */
   toggle(): void
-  /** Defines the title of the modal.*/
+  /** Defines the title of the modal. */
   title?: string
-  /** Defines the body of the modal.*/
+  /** Defines the body of the modal. */
   body?: ReactNode
   /**
    * Renders a close button in modal header.
    * @default true
-   **/
+   * */
   showHeaderCloseButton?: boolean
   /**
    * Defines if the modal should be vertically centered.
    * @default false
-   **/
+   * */
   verticallyCentered?: boolean
   /**
    * Defines the buttons alignment.
    * @default "edges"
-   **/
+   * */
   buttonsAlignment?: ButtonsAlignment
   /**
    * Optional close button properties.
-   **/
+   * */
   closeButton?: ButtonProps
   /**
    * Optional middle button properties.
-   **/
+   * */
   middleButton?: ButtonProps
   /**
    * Optional success button properties.
-   **/
+   * */
   successButton?: ButtonProps
 }
 
@@ -69,7 +69,7 @@ const Modal = (props: Props) => {
       onHide={() => toggle()}
     >
       {(showHeaderCloseButton === false ? title : true) && (
-        <BootstrapModal.Header closeButton={showHeaderCloseButton === false ? false : true}>
+        <BootstrapModal.Header closeButton={showHeaderCloseButton !== false}>
           {title && <BootstrapModal.Title>{title}</BootstrapModal.Title>}
         </BootstrapModal.Header>
       )}

stories/modal.stories.tsx

@@ -1,7 +1,6 @@
 import React, { useState } from 'react'
 import { storiesOf } from '@storybook/react'
-import { Modal } from '../src'
-import { Button } from '../src'
+import { Modal, Button } from '../src'
 
 storiesOf('Modal', module)
   .addParameters({
@@ -11,7 +10,9 @@ storiesOf('Modal', module)
       propTablesExclude: [Button],
     },
   })
-  .addDecorator(storyFn => <div style={{ marginLeft: '2em', marginRight: '2em' }}>{storyFn()}</div>)
+  .addDecorator((storyFn) => (
+    <div style={{ marginLeft: '2em', marginRight: '2em' }}>{storyFn()}</div>
+  ))
   .add('Simple modal', () => {
     const [show, setShow] = useState(false)
     return (

test/modal.test.tsx

@@ -1,11 +1,11 @@
 import * as React from 'react'
 import { shallow } from 'enzyme'
-import { Modal } from '../src'
 import BootstrapModal from 'react-bootstrap/Modal'
+import { Modal } from '../src'
 
 describe('Modal', () => {
   it('Modal renders itself without crashing', () => {
-    const modalWrapper = shallow(<Modal show={true} toggle={() => {}} />)
+    const modalWrapper = shallow(<Modal show toggle={() => {}} />)
     expect(modalWrapper.find(BootstrapModal)).toHaveLength(1)
   })
 })