Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support const graph methods #22

Open
1 task
Hoshiningen opened this issue May 8, 2020 · 0 comments
Open
1 task

Support const graph methods #22

Hoshiningen opened this issue May 8, 2020 · 0 comments
Labels
api Improvements to the API

Comments

@Hoshiningen
Copy link
Owner

The similarity and voronoi graphs both use an inherited implementation class to hide the implementation details from the compiler. The way this was implemented, it can't support having constant methods in the public API of the class that inherits from the implementation class.

This is not ideal, as external methods can't accept const types with that implementation class. They have to take them by value or by reference.

void Render(SimilarityGraph& simGraph)
{
   // This would be better if simGraph was constant because otherwise, it's able to modify the graph, and passing by value is expensive
}

Acceptance Criteria:

  • The implementation class that the Similarity and Voronoi Graphs use has been modified to allow constant operations
@Hoshiningen Hoshiningen added the api Improvements to the API label May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Improvements to the API
Projects
None yet
Development

No branches or pull requests

1 participant