Garbled error when set chinese in outline

[suninuni]

Hi @Hopding ,

I just tried to use chinese as outline item title(refer to #127 (comment)), but i got some garbled strings, e.g

Actually in the code, some of them are:

So, i found a pdf which has chinese in outline and print it in the console. They are also garbled strings, such as þÿ{,\\u00001zà\\u0000 g. But when i set þÿ{,\\u00001zà\\u0000 g as a outline item title, i got 第一章 in the result pdf's outline which is display in the right way.

Is there any suggestion to resole this?

Thank you.

Some informations which may be helpful:

• https://tex.stackexchange.com/questions/236863/incorrect-encoding-in-pdf-outlines/237277#237277

[inetfuture]

@Hopding any suggestions on this? thanks.

[suninuni]

https://tex.stackexchange.com/questions/236863/incorrect-encoding-in-pdf-outlines/237277#237277

According this, i found a function utf16Encode() in

pdf-lib/src/utils/unicode.ts

Lines 203 to 206 in 350c54b

	export const utf16Encode = (
	input: string,
	byteOrderMark = true,
	): Uint16Array => {

After this, i found PDFHexString.fromText() which used this function

pdf-lib/src/core/objects/PDFHexString.ts

Lines 17 to 26 in 350c54b

	static fromText = (value: string) => {
	const encoded = utf16Encode(value);
	let hex = '';
	for (let idx = 0, len = encoded.length; idx < len; idx++) {
	hex += toHexStringOfMinLength(encoded[idx], 4);
	}
	return new PDFHexString(hex);
	};

So i resolved this garbled problem by dict.set(PDFName.Title, title ? PDFHexString.fromText(title) : title);

And i saw you are working at #486 which about PDFOutline, so i recommend using PDFHexString.fromText instead of PDFString.of when set PDFName.Title in https://github.com/Hopding/pdf-lib/pull/486/files#diff-cf25ad19a97bf84bda22a1a3621dbdf1R28

Thank you anyway.