Skip to content

Conversation

@chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added perl Perl use is a significant feature of the PR or issue icu4c ICU use is a significant feature of the PR or issue labels Dec 19, 2024
@chenrui333 chenrui333 changed the title samba: fix incorrect install_name for shared libraries on macOS samba: fix incorrect install_name for shared libraries on macOS, legba 0.10.0 (new formula) Dec 19, 2024
@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Dec 19, 2024
@chenrui333 chenrui333 added the rust Rust use is a significant feature of the PR or issue label Dec 19, 2024
@chenrui333 chenrui333 mentioned this pull request Dec 19, 2024
6 tasks
@chenrui333 chenrui333 force-pushed the fix-macos-install_name branch from 91a6993 to f0998fa Compare December 19, 2024 21:28
@chenrui333 chenrui333 marked this pull request as ready for review December 19, 2024 21:28
@chenrui333 chenrui333 added automerge-skip `brew pr-automerge` will skip this pull request autobump labels Dec 19, 2024
Signed-off-by: Rui Chen <[email protected]>

samba: use upstream patch

Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: Rui Chen <[email protected]>

legba: add completions and autobump

Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 force-pushed the fix-macos-install_name branch from f0998fa to 4e6487f Compare December 19, 2024 21:43
@chenrui333
Copy link
Member Author

@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Dec 20, 2024
@github-actions
Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Dec 20, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 20, 2024
Merged via the queue into master with commit a6b358d Dec 20, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the fix-macos-install_name branch December 20, 2024 05:08
chenrui333 added a commit to chenrui333/legba that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autobump automerge-skip `brew pr-automerge` will skip this pull request CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. icu4c ICU use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core perl Perl use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green rust Rust use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants