-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
depends_on :java #7993
Comments
Yes, it has to be a special case. I made room for My rough and incomplete plan was
Then of course we'd like to install the needed Java version from a Cask. Since it is possible to have multiple Java versions it would be nice to support that by not overwriting an existing java. I'm not sure how much work that is. Also perhaps in that case we shouldn't trust what Lots of practical stuff to figure out. |
Ah, I didn't go beyond the documentation to the source code... to see that it's already prepared... :) Thanks for noticing. So the goal is to improve it and make it more practical then. |
"More practical" is a polite way to say it. I didn't do any of the implementation because I was worried I would miss something important. |
Homebrew has a working |
@tsparber They do, but it’s no use to use. The only thing it does is exit with an error and tell you java ins’t present but is needed. The first solution is a recommendation to install via homebrew-cask. We’re looking to actually install it. |
Closing in favour of #16383. |
I like the idea of
depends_on :cask => 'cask-name'
, but I feel, that it may not work well with the current naming convention incaskroom/homebrew-versions
, especially not with Java.It would has to allow some complicated combinations like:
which I don't see as a bad idea, but probably not for Java casks.
I'm not sure if it's something that the actual stanza should be solving or whether we should rather think about better naming convention and more functional metadata - e.g.
brew cask install java -v 7
Either way we already have many casks (IntelliJ IDEs including Android Studio), that depends on Java, but in reality it's usually any java, not a particular version.
I'm just opening discussion here to get some feedback and eventually get to some suggestions/solutions.
The text was updated successfully, but these errors were encountered: