Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after_install / postflight mini-DSL #5268

Closed
rolandwalker opened this issue Jul 9, 2014 · 3 comments
Closed

after_install / postflight mini-DSL #5268

rolandwalker opened this issue Jul 9, 2014 · 3 comments

Comments

@rolandwalker
Copy link
Contributor

after_install (soon to be renamed postflight) and other similar blocks should have a mini-DSL for common functionality, like caveats does.

references: #5266.

@federicobond
Copy link
Contributor

What common functionality, besides #5266, is needed here?

@rolandwalker
Copy link
Contributor Author

Definitely wanted:

  • enable accessibility access #5266, accessibility
  • Suppress "move to applications" as in alfred.rb
  • A front-end to SystemCommand.run that accepts only list-form commands (and then consider disabling system within the mini-DSL)

Wishlist:

  • A wrapper for PlistBuddy that reduces boilerplate. For example, once we change link to app, Info.plist has a default location. So this line from pycharm.rb

    system "/usr/libexec/PlistBuddy", "-c", "Set :JVMOptions:JVMVersion 1.6+", "#{destination_path}/PyCharm.app/Contents/Info.plist"

    might be reduceable to

    plist_set(':JVMOptions:JVMVersion', '1.6+')
  • A wrapper for ln might have a few advantages: better error reporting, and control of behavior when the file already exists.

  • Anything else that shows up more than two or three times in after_install is a candidate.

@rolandwalker
Copy link
Contributor Author

Also

  • ability to quit apps, unload launchctl services, etc as is available in uninstall
  • ability to remove icons from the Dock

@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants