Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail when passing arguments to cleanup #21763

Closed
wfdd opened this issue Jun 7, 2016 · 3 comments
Closed

Fail when passing arguments to cleanup #21763

wfdd opened this issue Jun 7, 2016 · 3 comments

Comments

@wfdd
Copy link
Contributor

wfdd commented Jun 7, 2016

I thought I could clear out the cache of a specific cask but it seems not:

$ brew cask cleanup atom-beta
==> Removing dead symlinks
Nothing to do
==> Removing cached downloads
/Users/.../Library/Caches/Homebrew/vlc-2.2.4.dmg
/Users/.../Library/Caches/Homebrew/atom-beta-1.9.0-beta0.zip
/Users/.../Library/Caches/Homebrew/basictex-20160523.pkg
/Users/.../Library/Caches/Homebrew/Casks/basictex-20160523.pkg
/Users/.../Library/Caches/Homebrew/Casks/vlc-2.2.4.dmg
/Users/.../Library/Caches/Homebrew/Casks/atom-beta-1.9.0-beta0.zip
==> This operation has freed approximately 486.3M of disk space.

Rather than deleting everything, cask should warn the cleanup command doesn't take any arguments. I think that'd be better from a usability perspective.

@jawshooah
Copy link
Contributor

Alternatively, cleanup could actually take cask token arguments and work as you expect. I believe there was an old issue requesting this behavior, but I'm on mobile so I can't verify.

@vitorgalvao
Copy link
Member

@jawshooah Could this perhaps be something we inherit from HB with the merger?

@vitorgalvao vitorgalvao added the awaiting maintainer feedback Issue needs response from a maintainer. label Jun 12, 2016
@jawshooah jawshooah self-assigned this Jul 7, 2016
@jawshooah jawshooah added enhancement core Issue with Homebrew itself rather than with a specific cask. labels Jul 7, 2016
@reitermarkus
Copy link
Member

Closing this in favour of #23398.

@reitermarkus reitermarkus removed the awaiting maintainer feedback Issue needs response from a maintainer. label Aug 3, 2016
@miccal miccal removed core Issue with Homebrew itself rather than with a specific cask. enhancement labels Dec 23, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants