Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention updating appcast’s sha256 in contributing.md #16464

Closed
vitorgalvao opened this issue Jan 7, 2016 · 2 comments
Closed

Mention updating appcast’s sha256 in contributing.md #16464

vitorgalvao opened this issue Jan 7, 2016 · 2 comments

Comments

@vitorgalvao
Copy link
Member

I’m currently updating a bunch of casks to their latest versions. In some cases, that means updating simply the appcast’s :sha256 (as everything else is fine, though I am checking every one of them individually).

Some of them have versionless URLs, and some others (so far, just one), were switched from a versioned to a versionless URL (since we can take advantage of CDN like that). Since those casks have appcasts, that is actually a good thing since we can still keep the advantages of versions.

After updating all of them, I’ll start working on the script to check appcasts (that will open issues automatically).

@caskroom/maintainers This means that (finally) from now on updates to casks must include updates to appcast’s :sha256 as well, and we must ask contributors do so/fix the PRs when they miss it. This also means there should be a short description in CONTRIBUTING.md to explain why and how to do it.

@vitorgalvao vitorgalvao added the documentation Issue regarding documentation. label Jan 7, 2016
@adidalal
Copy link
Contributor

adidalal commented Jan 7, 2016

I can take care of it as part of #16373

Will be working on that over the next day or so.

@adidalal adidalal self-assigned this Jan 7, 2016
@vitorgalvao
Copy link
Member Author

Thank you for doing so. Closing in favour of #16373.

@adidalal adidalal removed their assignment Jan 23, 2016
@miccal miccal removed the documentation Issue regarding documentation. label Dec 23, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants