From a043e7bbf8a5c9d268ee1099f4449360b0c2e4be Mon Sep 17 00:00:00 2001 From: botantony Date: Tue, 29 Apr 2025 21:49:25 +0200 Subject: [PATCH 1/2] tap: fix autobump logic for unofficial taps Signed-off-by: botantony --- Library/Homebrew/tap.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Library/Homebrew/tap.rb b/Library/Homebrew/tap.rb index 05bb1d2d37767..2cf80ed4a5a43 100644 --- a/Library/Homebrew/tap.rb +++ b/Library/Homebrew/tap.rb @@ -987,8 +987,10 @@ def self.tap_migration_oldnames(current_tap, name_or_token) def autobump autobump_packages = if core_cask_tap? Homebrew::API::Cask.all_casks - else + elsif core_tap? Homebrew::API::Formula.all_formulae + else + {} end @autobump ||= autobump_packages.select do |_, p| From 1791c2e2a60f8773bf2587c709bf7793f2c7cbd4 Mon Sep 17 00:00:00 2001 From: botantony Date: Tue, 29 Apr 2025 22:38:14 +0200 Subject: [PATCH 2/2] tap_auditor: do not audit `autobump.txt` in official taps Signed-off-by: botantony --- Library/Homebrew/tap_auditor.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Library/Homebrew/tap_auditor.rb b/Library/Homebrew/tap_auditor.rb index a6fa8b307acb3..f792fd78ccd0c 100644 --- a/Library/Homebrew/tap_auditor.rb +++ b/Library/Homebrew/tap_auditor.rb @@ -17,6 +17,7 @@ def initialize(tap, strict:) @tap_style_exceptions = tap.style_exceptions @tap_pypi_formula_mappings = tap.pypi_formula_mappings @tap_autobump = tap.autobump + @tap_official = tap.official? @problems = [] @cask_tokens = tap.cask_tokens.map do |cask_token| @@ -54,8 +55,8 @@ def audit_tap_formula_lists check_formula_list_directory "audit_exceptions", @tap_audit_exceptions check_formula_list_directory "style_exceptions", @tap_style_exceptions check_formula_list "pypi_formula_mappings", @tap_pypi_formula_mappings - check_formula_list ".github/autobump.txt", @tap_autobump check_formula_list "formula_renames", @formula_renames.values + check_formula_list ".github/autobump.txt", @tap_autobump unless @tap_official end sig { void }