Switch to ESLint

Author: Hirse

.eslintrc.json

@@ -0,0 +1,21 @@
+{
+    "root": true,
+    "parser": "@typescript-eslint/parser",
+    "parserOptions": {
+        "ecmaVersion": 6,
+        "sourceType": "module"
+    },
+    "env": { "node": true },
+    "globals": { "Thenable": false },
+    "plugins": ["@typescript-eslint"],
+    "extends": ["eslint:recommended", "plugin:@typescript-eslint/recommended"],
+    "rules": {
+        "@typescript-eslint/naming-convention": "warn",
+        "@typescript-eslint/semi": "warn",
+        "curly": "warn",
+        "eqeqeq": "warn",
+        "no-throw-literal": "warn",
+        "semi": "off"
+    },
+    "ignorePatterns": ["out", "**/*.d.ts"]
+}

.vscode/extensions.json

@@ -2,7 +2,7 @@
     // See http://go.microsoft.com/fwlink/?LinkId=827846
     // for the documentation about the extensions.json format
     "recommendations": [
-        "EditorConfig.EditorConfig",
-        "ms-vscode.vscode-typescript-tslint-plugin"
+        "dbaeumer.vscode-eslint",
+        "EditorConfig.EditorConfig"
     ]
 }

.vscodeignore

@@ -12,4 +12,3 @@ test/**
 **/*.map
 .gitignore
 tsconfig.json
-tslint.json

package.json

@@ -82,7 +82,7 @@
     "package": "vsce package",
     "postinstall": "patch-package",
     "publish": "vsce publish",
-    "test": "tslint -t verbose -p tsconfig.json"
+    "test": "eslint src/*"
   },
   "dependencies": {
     "ungit": "1.5.6",
@@ -91,9 +91,11 @@
   "devDependencies": {
     "@types/node": "12.x.x",
     "@types/vscode": "1.x.x",
+    "@typescript-eslint/eslint-plugin": "5.x.x",
+    "@typescript-eslint/parser": "5.x.x",
+    "eslint": "8.x.x",
     "patch-package": "6.x.x",
     "postinstall-postinstall": "2.x.x",
-    "tslint": "6.x.x",
     "typescript": "3.8.x",
     "vsce": "2.13.x"
   },

src/extension.ts

@@ -89,7 +89,7 @@ function openInWorkspace(workspaceFolder: WorkspaceFolder): void {
             child = fork(modulePath, parameter, { silent: true });
             const showInActiveColumn = workspace.getConfiguration("ungit", workspaceFolder.uri).get<boolean>("showInActiveColumn") === true;
             const viewColumn = showInActiveColumn ? ViewColumn.Active : ViewColumn.Beside;
-            child.stdout!.on("data", (message: Buffer) => {
+            child.stdout?.on("data", (message: Buffer) => {
                 const started =
                     (message.toString().includes("## Ungit started ##")) ||
                     (message.toString().includes("Ungit server already running")) ||
@@ -110,7 +110,7 @@ function openInWorkspace(workspaceFolder: WorkspaceFolder): void {
                     resolve();
                 }
             });
-            child.stderr!.on("error", (error) => {
+            child.stderr?.on("error", (error) => {
                 window.showErrorMessage(`Error opening Ungit: "${error.message}"`);
                 telemetryReporter.sendTelemetryException(error);
                 reject();