Skip to content

Commit a4e17d6

Browse files
paliLorenzo Pieralisi
authored andcommitted
PCI: aardvark: Fix PCIe Max Payload Size setting
Change PCIe Max Payload Size setting in PCIe Device Control register to 512 bytes to align with PCIe Link Initialization sequence as defined in Marvell Armada 3700 Functional Specification. According to the specification, maximal Max Payload Size supported by this device is 512 bytes. Without this kernel prints suspicious line: pci 0000:01:00.0: Upstream bridge's Max Payload Size set to 256 (was 16384, max 512) With this change it changes to: pci 0000:01:00.0: Upstream bridge's Max Payload Size set to 256 (was 512, max 512) Link: https://lore.kernel.org/r/[email protected] Fixes: 8c39d71 ("PCI: aardvark: Add Aardvark PCI host controller driver") Signed-off-by: Pali Rohár <[email protected]> Signed-off-by: Marek Behún <[email protected]> Signed-off-by: Lorenzo Pieralisi <[email protected]> Reviewed-by: Marek Behún <[email protected]> Cc: [email protected]
1 parent 460275f commit a4e17d6

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/pci/controller/pci-aardvark.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -488,8 +488,9 @@ static void advk_pcie_setup_hw(struct advk_pcie *pcie)
488488
reg = advk_readl(pcie, PCIE_CORE_PCIEXP_CAP + PCI_EXP_DEVCTL);
489489
reg &= ~PCI_EXP_DEVCTL_RELAX_EN;
490490
reg &= ~PCI_EXP_DEVCTL_NOSNOOP_EN;
491+
reg &= ~PCI_EXP_DEVCTL_PAYLOAD;
491492
reg &= ~PCI_EXP_DEVCTL_READRQ;
492-
reg |= PCI_EXP_DEVCTL_PAYLOAD; /* Set max payload size */
493+
reg |= PCI_EXP_DEVCTL_PAYLOAD_512B;
493494
reg |= PCI_EXP_DEVCTL_READRQ_512B;
494495
advk_writel(pcie, reg, PCIE_CORE_PCIEXP_CAP + PCI_EXP_DEVCTL);
495496

0 commit comments

Comments
 (0)