Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade suggested if upgrade is required #256

Open
mdrmdrmdr opened this issue Dec 30, 2017 · 1 comment
Open

Downgrade suggested if upgrade is required #256

mdrmdrmdr opened this issue Dec 30, 2017 · 1 comment

Comments

@mdrmdrmdr
Copy link

My kernel: Linux raspberry 4.9.70-v7+

Command "BRANCH=next JUST_CHECK=1 rpi-update" gives the message "Firmware downgrade requested". I think function "compare_hashes" just checks on dates. Shouldn't it check on dates AND version?

Regarding the date, latest 4.14 in branch "next" ist older than latest 4.9 in branch "master". So a date only compare makes no sense here...

__
[Started this accidentally @rpi-firmware...]

@lurch
Copy link
Contributor

lurch commented Jun 8, 2019

I think the only way to fix that would be to store the last-updated branch in e.g. .firmware_branch; and then JUST_CHECK would be able to display a more useful message if BRANCH doesn't match .firmware_branch, rather than just assuming it's doing a downgrade?
Not sure if that's worth it though, as (I think) the downgrade message will only be erroneously displayed the first time you switch branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants