Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes logs are not strictly sequential #45

Closed
timothyb89 opened this issue Oct 29, 2019 · 0 comments · Fixed by #52
Closed

Kubernetes logs are not strictly sequential #45

timothyb89 opened this issue Oct 29, 2019 · 0 comments · Fixed by #52
Labels
bug Something isn't working

Comments

@timothyb89
Copy link
Contributor

timothyb89 commented Oct 29, 2019

Logs from the Kubernetes reader aren't strictly sequential. This makes output potentially confusing, but isn't really trivial to solve.

Log messages from different pods obviously don't need to arrive at the same time since we're grabbing all logs since a pod was started, in parallel. We can't change stdout renderers' output after a message is printed, plus it'd be challenging to inform users that a new message arrived some arbitrary number of pages into the past even if we could.

The only 'easy' solutions I can immediately think of:

  • hold messages in a buffer for a bit and try to ensure output is ordered
    • we'll still have to release out-of-order messages eventually (unless discarding is an option...) but at least we can improve the situation
    • possibly 10s buffer at first run and reduce it once we've been running, to allow for initial out-of-order log ingest. logs tend to be ordered once we've caught up on the backlog
  • in addition to a buffer, add an option to discard or somehow flag messages as being out-of-order
  • alternatively / additionally, support random insertion in the interactive viewer. this would most likely seriously hurt performance, and have bad UX

A --tail option will mitigate this issue a bit (#33)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant