From 5509d2bef358a4fec26b2eaf4204ca52f134be48 Mon Sep 17 00:00:00 2001 From: LenaWil Date: Sat, 28 Dec 2024 17:36:40 +0100 Subject: [PATCH 1/2] Fix capitalisation of Heroic in GlobalState.tsx I noticed it while translating. --- src/frontend/state/GlobalState.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/frontend/state/GlobalState.tsx b/src/frontend/state/GlobalState.tsx index aa93cd0d1d..3de5aca8b4 100644 --- a/src/frontend/state/GlobalState.tsx +++ b/src/frontend/state/GlobalState.tsx @@ -430,7 +430,7 @@ class GlobalState extends PureComponent { title: t('box.reset-heroic.question.title', 'Reset Heroic'), message: t( 'box.reset-heroic.question.message', - "Are you sure you want to reset Heroic? This will remove all Settings and Caching but won't remove your Installed games or your Epic credentials. Portable versions (AppImage, WinPortable, ...) of heroic needs to be restarted manually afterwards." + "Are you sure you want to reset Heroic? This will remove all Settings and Caching but won't remove your Installed games or your Epic credentials. Portable versions (AppImage, WinPortable, ...) of Heroic needs to be restarted manually afterwards." ), buttons: [ { text: t('box.yes'), onClick: window.api.resetHeroic }, From f1cbc88cb6e105cd67cd2f527dfba66fc31d2b32 Mon Sep 17 00:00:00 2001 From: Lena Wildervanck Date: Tue, 21 Jan 2025 18:29:34 +0100 Subject: [PATCH 2/2] More capitalization fixes --- e2e/webview_controls.spec.ts | 2 +- public/locales/en/translation.json | 4 ++-- src/frontend/helpers/gamepad.ts | 2 +- src/frontend/helpers/shortcuts.ts | 2 +- src/frontend/screens/Settings/components/ResetHeroic.tsx | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/e2e/webview_controls.spec.ts b/e2e/webview_controls.spec.ts index b3898713ff..f5be4758df 100644 --- a/e2e/webview_controls.spec.ts +++ b/e2e/webview_controls.spec.ts @@ -5,7 +5,7 @@ import { WebviewTag } from 'electron' electronTest('webview', async (app) => { const page = await app.firstWindow() - await test.step('goes back and forth inside webview and also to heroic screens', async () => { + await test.step('goes back and forth inside webview and also to Heroic screens', async () => { // we have to do this or it fails, the icon also has the same text await page.locator('span').filter({ hasText: 'Documentation' }).click() diff --git a/public/locales/en/translation.json b/public/locales/en/translation.json index bdcac18ef2..be873a112d 100644 --- a/public/locales/en/translation.json +++ b/public/locales/en/translation.json @@ -111,7 +111,7 @@ }, "reset-heroic": { "question": { - "message": "Are you sure you want to reset Heroic? This will remove all Settings and Caching but won't remove your Installed games or your Epic credentials. Portable versions (AppImage, WinPortable, ...) of heroic needs to be restarted manually afterwards.", + "message": "Are you sure you want to reset Heroic? This will remove all Settings and Caching but won't remove your Installed games or your Epic credentials. Portable versions (AppImage, WinPortable, ...) of Heroic needs to be restarted manually afterwards.", "title": "Reset Heroic" } }, @@ -764,7 +764,7 @@ }, "details": "Details", "resetHeroic": { - "help": "This will remove all Settings and Caching but won't remove your Installed games or your Epic credentials. Portable versions (AppImage, WinPortable, ...) of heroic needs to be restarted manually afterwards." + "help": "This will remove all Settings and Caching but won't remove your Installed games or your Epic credentials. Portable versions (AppImage, WinPortable, ...) of Heroic needs to be restarted manually afterwards." }, "title": { "clearCache": "Clear Cache", diff --git a/src/frontend/helpers/gamepad.ts b/src/frontend/helpers/gamepad.ts index 5ea8b46d02..b914206e09 100644 --- a/src/frontend/helpers/gamepad.ts +++ b/src/frontend/helpers/gamepad.ts @@ -69,7 +69,7 @@ export const initGamepad = () => { if (controllerIsDisabled) return if (!isFocused) { - // ignore gamepad events if heroic is not the focused app + // ignore gamepad events if Heroic is not the focused app // // the browser still detects the gamepad interactions even // if the screen is not focused when playing a game diff --git a/src/frontend/helpers/shortcuts.ts b/src/frontend/helpers/shortcuts.ts index d3125187ea..5368329d38 100644 --- a/src/frontend/helpers/shortcuts.ts +++ b/src/frontend/helpers/shortcuts.ts @@ -10,7 +10,7 @@ export const initShortcuts = () => { // Ctrl+L or Cmd+L, show library // Ctrl+J or Cmd+J, download manager // Ctrl+K or Cmd+K, settings - // Ctrl+Q or Cmd+Q, quit heroic + // Ctrl+Q or Cmd+Q, quit Heroic if (['r', 'j', 'k', 'l', 'q'].includes(e.key)) { window.api.processShortcut(`ctrl+${e.key}`) } diff --git a/src/frontend/screens/Settings/components/ResetHeroic.tsx b/src/frontend/screens/Settings/components/ResetHeroic.tsx index 4613b62913..627cef2912 100644 --- a/src/frontend/screens/Settings/components/ResetHeroic.tsx +++ b/src/frontend/screens/Settings/components/ResetHeroic.tsx @@ -16,7 +16,7 @@ const ResetHeroic = () => { {t( 'settings.advanced.resetHeroic.help', - "This will remove all Settings and Caching but won't remove your Installed games or your Epic credentials. Portable versions (AppImage, WinPortable, ...) of heroic needs to be restarted manually afterwards." + "This will remove all Settings and Caching but won't remove your Installed games or your Epic credentials. Portable versions (AppImage, WinPortable, ...) of Heroic needs to be restarted manually afterwards." )}