Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Letters get duplicated on website #225

Closed
Helium314 opened this issue Oct 20, 2023 · 6 comments
Closed

Letters get duplicated on website #225

Helium314 opened this issue Oct 20, 2023 · 6 comments
Labels
bug Something isn't working low priority This issue is unlikely to be resolved in the near future due to maintainers' priorities

Comments

@Helium314
Copy link
Owner

Helium314 commented Oct 20, 2023

Does it happen in OpenBoard, or is it exclusive to this modified version?
only this fork

To Reproduce
Steps to reproduce the behavior:

  1. have auto-correct and suggestions enabled (and always show suggestions)
  2. go to https://bdz.bg
  3. enter two letters in the right search field
  4. see the first letter being duplicated as soon as you enter the second one

Expected behavior
no duplicate letters

App version
at least v10, probably all

Additional context
The problem does not occur when not using always show suggestions. But there are request to show suggestions in such fields, and ideally the keyboard should decide for which fields this is safe...

@Helium314 Helium314 added the bug Something isn't working label Oct 20, 2023
@Helium314 Helium314 added the low priority This issue is unlikely to be resolved in the near future due to maintainers' priorities label Nov 21, 2023
@meichthys
Copy link

You already may know this, but if you turn off the following two options in the settings, this issue does not happen.
ResizedImage_Screenshot_20240106-085750.png_2024-01-06_08-58-35_1876.png

Obviously turning this settings off is not ideal, so it would be nice to have a better fix.

@Helium314
Copy link
Owner Author

The difference between suggestions on and off is that without suggestions, commitText is used, and with suggestions setComposingText is used to set the text.

setComposingText gives the underline, indicating that it's the currently typed word. But apparently just using this function is enough to cause trouble. This is a reason to actually do what the NO_SUGGESTIONS flag wants.

Maybe there is a way to still use/show suggestions, but with commitText instead of setComposingText for those text fields.

Not sure if there are other keyboards that allow showing suggestions in this field, but if so maybe we can copy some code.

@ccoVeille
Copy link

Thanks for fixing this 👍

@Helium314
Copy link
Owner Author

We'll see whether it's full fixed. I can't reproduce the bug with the steps in the first post, but there might be similar situations where it still occurs.

@starkgate
Copy link

@Helium314 Thank you very much for working on this issue. I believe it is a duplicate of #662 . I tested the new version 2.0-beta2 and noticed improvement but it's not completely fixed. The website I've tested on is wanikani.com (see the issue for more details). The first character I type is much less often duplicated than it used to, but it is still possible to cause the duplication by typing very fast. In practice I believe typing this fast would rarely happen, at least for me personally I had to type as fast as possible with a specific sequence of letters (I tried 'koko' for example). Typing a little slower won't cause the issue to happen.

@Helium314
Copy link
Owner Author

I believe it is a duplicate of #662

Not really, because the website above does a latin -> cyrillic conversion that messes with the cached text. This is not happening in examples like "OOf Course".
But it looks like the issue is related, possibly the app/website somehow also messes with the composing text (i.e. the underlined text),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low priority This issue is unlikely to be resolved in the near future due to maintainers' priorities
Projects
None yet
Development

No branches or pull requests

4 participants