Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enter key does not work #1415

Open
rusty-snake opened this issue Mar 10, 2025 · 9 comments
Open

Enter key does not work #1415

rusty-snake opened this issue Mar 10, 2025 · 9 comments
Labels
bug Something isn't working

Comments

@rusty-snake
Copy link

Describe the bug

The enter key of HeliBoard does not work on some input fields. AOSP Keyboard as well as KeePassDX Magic Keyboards enter keys work.

To Reproduce

  • enter some text, then try to "submit" it.
  • Known broken on
    • GitHub issue search
    • Android 15 QPR 2 Developer Options Linux Terminal

Expected behavior
Same as AOSP Keyboard / submit works.

App version
2.3

Device:

  • Model: Pixel 6
  • OS: GrapheneOS (AOSP 15 QPR 2)
@rusty-snake rusty-snake added the bug Something isn't working label Mar 10, 2025
@Helium314
Copy link
Owner

I guess this is another of the commitText vs sending a fake keypress situations...

Did you also try OpenBoard? No need to try if you haven't.

GitHub issue search

Which browser? Probably the only relevant thing is WeView / Firefox / Chromium based.

@rusty-snake
Copy link
Author

rusty-snake commented Mar 13, 2025

Did you also try OpenBoard?

No

Which browser?

Vanadium/Brave (Chromium)

I guess this is another of the commitText vs sending a fake keypress situations...

W/o knowing the details of Androids input system, but the description looks very much like what I see in the UI.

@Helium314
Copy link
Owner

Vanadium/Brave (Chromium)

I just tried Cromite, and there it works with GitHub issue search.
Is the action key icon an arrow pointing to the right in the GitHub search? Because it is for me, and in that case neither commitText nor a fake keypress is sent, but performEditorAction, which I'm sure is also called by AOSP keyboard.

@rusty-snake
Copy link
Author

Is the action key icon an arrow pointing to the right in the GitHub search?

(in HB) Yes.

This btw started with GH rolling out the "new" issue search form field.

@Helium314
Copy link
Owner

Looks like it's a Brave issue, and not Chromium in general. Can reproduce it there.

@rusty-snake
Copy link
Author

Well in Vanadium does it not work either. While it could be a thing that was changed on both. Or something related to android version, ...

@rusty-snake
Copy link
Author

Not for the Terminal problem. But for GH it works if I press enter/arrow when there is a space before the cursor rather than an letter.

@Helium314
Copy link
Owner

I just tried again, and can't reproduce it any more... added some logging, and performEditorAction is always called as expected.
The directly involved code is the same as in OpenBoard and AOSP Keyboard.

@rusty-snake
Copy link
Author

Terminal: After the latest update of it, the commitText story works better. Disabling autocomplete (more autocomplete was enabled) makes enter key just work (although FUTO Keyboard also auto-miss-completes words but does not break the input). However HB seems to be the only Keyboad I tested where the backspace key never works (for some apps it only works the second time I press it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants