Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make toolbar-suggestions switch key larger, and highlight it when suggestions are available #1412

Open
eranl opened this issue Mar 9, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@eranl
Copy link
Contributor

eranl commented Mar 9, 2025

Hitting the small arrow for switching between the toolbar and suggestions is often tough, taking a few tries.
Also, when toolbar auto-hide is off, you can't tell if there are suggestions available to switch to.

I suggest:

  1. Make the key larger (3-character wide?), possibly with appropriate icons
  2. Highlight it in color or similar when in toolbar mode and suggestions are available

I'm happy to implement this.

@eranl eranl added the enhancement New feature or request label Mar 9, 2025
@Helium314
Copy link
Owner

Hitting the small arrow for switching between the toolbar and suggestions is often tough, taking a few tries.

I sometimes also notice this, and I somewhat suspect there is something else going on that not the whole area is registering the click.

Make the key larger (3-character wide?)

I don't know how wide your character is here, but I would like to avoid a considerable increase in size.

Highlight it in color or similar when in toolbar mode and suggestions are available

Not sure about this, what do you have in mind? Background or icon, and how much color change.
On one had it would be a neat indicator, on the other hand I fear such a feature could be confusing as the reason for the color change might not be clear to users.

Actually that's 2 separate issues in my opinion (key highlight color, and size / touch problem). When doing PRs I'd definitiely prefer it separated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants