Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non shift keys behave like shift keys #1256

Closed
eqoffical opened this issue Dec 23, 2024 · 1 comment
Closed

Non shift keys behave like shift keys #1256

eqoffical opened this issue Dec 23, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@eqoffical
Copy link

On toggle between symbols and function keys selected text changes between capitalization as if it were a shift key.

To Reproduce

  1. Select a text
  2. Press on the symbol layout button (it's labeled as ?123)
  3. Toggle between symbol and function layouts (they're labeled as ?123 and =\< respectively)

Expected behavior
This action should not change the capitalization, these buttons are not shift keys.

Screenshots
https://github.com/user-attachments/assets/f63e4209-dd32-40ed-9c56-b9ef0acc3e60

App version: 2.2

Device:

  • Model: Pixel 7 Pro
  • OS: Android 15, GrapheneOS
@eqoffical eqoffical added the bug Something isn't working label Dec 23, 2024
@PurplePickleMonster
Copy link
Contributor

PurplePickleMonster commented Dec 31, 2024

I was able to reproduce this and started looking at it. That key is being interpreted as the shift key when I press it

2024-12-30 22:28:29.729 12744-12744 KeyboardState           helium314.keyboard.debug             D  onPressKey: code=shift single=true [keyboard=SYMBOLS shift=RELEASING symbol=RELEASING switch=SYMBOL-BEGIN] autoCapsFlags=none recapitalizeMode=undefined
2024-12-30 22:28:29.730 12744-12744 KeyboardState           helium314.keyboard.debug             D  setSymbolsShiftedKeyboard
2024-12-30 22:28:29.740 12744-12762 EGL_emulation           helium314.keyboard.debug             D  app_time_stats: avg=5950.11ms min=150.85ms max=11749.36ms count=2
2024-12-30 22:28:40.154 12744-12744 KeyboardState           helium314.keyboard.debug             D  onPressKey: code=shift single=true [keyboard=SYMBOLS_SHIFTED shift=RELEASING symbol=RELEASING switch=SYMBOL-BEGIN] autoCapsFlags=none recapitalizeMode=undefined
2024-12-30 22:28:40.154 12744-12744 KeyboardState           helium314.keyboard.debug             D  setSymbolsKeyboard
2024-12-30 22:28:40.173 12744-12762 EGL_emulation           helium314.keyboard.debug             D  app_time_stats: avg=5216.67ms min=165.19ms max=10268.15ms count=2

I'm still looking but, I think the problem is using the shift key for multiple purposes and just relabeling it when switching to symbols, which has the side effect of performing the shift action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants