-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spike: Change Approval API #37
Open
fundthmcalculus
wants to merge
17
commits into
HealthITAU:main
Choose a base branch
from
fundthmcalculus:feat/change-approval
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
spike: Change Approval API #37
fundthmcalculus
wants to merge
17
commits into
HealthITAU:main
from
fundthmcalculus:feat/change-approval
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fundthmcalculus
force-pushed
the
feat/change-approval
branch
from
September 23, 2024 14:26
2173c1f
to
557156e
Compare
fundthmcalculus
force-pushed
the
feat/change-approval
branch
from
September 23, 2024 15:58
31cb6e3
to
ec41438
Compare
fundthmcalculus
force-pushed
the
feat/change-approval
branch
from
September 23, 2024 17:11
fb064b0
to
b303d1e
Compare
fundthmcalculus
force-pushed
the
feat/change-approval
branch
from
September 23, 2024 19:18
56a4238
to
431a180
Compare
@Yoshify I'd appreciate some thoughts on this:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is definitely a work in progress, but I have been able to start reverse-engineering the Change Approval board API. It clearly runs on the
changeapproval
cookie, which I need to figure out how to extract more intelligently (since it expires every day). That being said, I have successfully extracted a (test) change approval by ID and confirmed the contents.I'll keep working on this, extending the endpoints as I can figure them out - it uses a different API structure, but I have a python script written which can convert the JSON object from Chrome Developer console into python (pydantic) models. It's a 95% solution (doesn't know import ordering, occasionally gets a type wrong, etc), but it's pretty handy. If interested, I can include it too.
Here is an example (with a number of IDs, and coworker details censored):