Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spike: Change Approval API #37

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

fundthmcalculus
Copy link
Contributor

This is definitely a work in progress, but I have been able to start reverse-engineering the Change Approval board API. It clearly runs on the changeapproval cookie, which I need to figure out how to extract more intelligently (since it expires every day). That being said, I have successfully extracted a (test) change approval by ID and confirmed the contents.

I'll keep working on this, extending the endpoints as I can figure them out - it uses a different API structure, but I have a python script written which can convert the JSON object from Chrome Developer console into python (pydantic) models. It's a 95% solution (doesn't know import ordering, occasionally gets a type wrong, etc), but it's pretty handy. If interested, I can include it too.

Here is an example (with a number of IDs, and coworker details censored):

image

@fundthmcalculus fundthmcalculus marked this pull request as ready for review September 24, 2024 14:22
@fundthmcalculus
Copy link
Contributor Author

@Yoshify I'd appreciate some thoughts on this:

  1. General direction - is this something we want to support?
  2. Architecture - the Change Approvals module has a different API, so I was trying to make this look familiar to the rest of the api.
  3. Anything else - I added tests for my environment to confirm functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant