Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aseprite Atlas repeat value to follow editor convention #2947

Open
MondayHopscotch opened this issue Oct 24, 2023 · 0 comments
Open

Aseprite Atlas repeat value to follow editor convention #2947

MondayHopscotch opened this issue Oct 24, 2023 · 0 comments

Comments

@MondayHopscotch
Copy link
Contributor

  • Flixel version: 5.4.1

Aseprite editor behavior is as follows:

Tag's Repeat Checkbox Tag's Repeat Field Value Tag Looping behavior
  • Repeat
N/A Loops Forever
  • Repeat
1 Plays a single time, stopping at the final frame
  • Repeat
>1 Plays N times

Currently, AseAtlas parses the loops value as:

inline function get_loops()
{
	return this != null && toInt() > 0;
}

However, in the Aseprite editor, tags default to looping, represented by the Repeat field on the tag being unchecked.

Current Flixel parsed behavior:

Tag's Repeat Checkbox Tag's Repeat Field Value Flixel Animation parsed loops value
  • Repeat
N/A false
  • Repeat
1 true
  • Repeat
>1 true

Desired Flixel parsed behavior:

Tag's Repeat Checkbox Tag's Repeat Field Value Flixel Animation parsed loops value
  • Repeat
N/A true
  • Repeat
1 false
  • Repeat
>1 true

With this behavior, the only gap between Aseprite and Flixel is in the case where Repeat is >1, as Flixel does not have a built-in notion of playing an animation x times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant