fix: Flappybalt: bounce panels resetting thier sprites to default on resetState()
#372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geokureli
requested changes
Jan 3, 2025
There was a problem hiding this comment.
Should we remove Reg._bitmapData and Reg._rect since it's seems to be no longer cached
If so than please rename this to createBounceImage, have these two calls use the same bitmapData instance via:
// The bounce panels. Drawn via code in Reg to fit screen height.
final bounceImage = Reg.createBounceImage(FlxG.height - 34);
// The left bounce panel.
_bounceLeft = new FlxSprite(1, 17);
_bounceLeft.loadGraphic(bounceImage, true, 4, FlxG.height - 34);
_bounceLeft.animation.add("flash", [1, 0], 8, false);
add(_bounceLeft);
// The right bounce panel.
_bounceRight = new FlxSprite(FlxG.width - 5, 17);
_bounceRight.loadGraphic(bounceImage, true, 4, FlxG.height - 34);
_bounceRight.animation.add("flash", [1, 0], 8, false);
add(_bounceRight);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #366
See my lil comment there on null stuff