From 7ca39b0bac82bc38729aec0f052197cf3404f68b Mon Sep 17 00:00:00 2001 From: Alex Ruzenhack Date: Thu, 26 Oct 2023 22:28:37 +0100 Subject: [PATCH 1/2] fix: promise leak by capturing rejection from getVersion --- src/new/wallet.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/new/wallet.js b/src/new/wallet.js index 90c259511..1e74f4056 100644 --- a/src/new/wallet.js +++ b/src/new/wallet.js @@ -227,8 +227,8 @@ class HathorWallet extends EventEmitter { * @inner **/ async getVersionData() { - const versionData = await new Promise(resolve => { - versionApi.getVersion(resolve) + const versionData = await new Promise((resolve, reject)=> { + versionApi.getVersion(resolve).catch((error) => reject(error)) }); return { @@ -1312,8 +1312,8 @@ class HathorWallet extends EventEmitter { this.walletStopped = false; this.setState(HathorWallet.CONNECTING); - const info = await new Promise(resolve => { - versionApi.getVersion(resolve); + const info = await new Promise((resolve , reject)=> { + versionApi.getVersion(resolve).catch((error) => reject(error)); }); if (info.network.indexOf(this.conn.network) >= 0) { this.storage.setApiVersion(info); From 1a1ef766ec83437375738d1f6831f8d30c523f8d Mon Sep 17 00:00:00 2001 From: Alex Ruzenhack Date: Mon, 30 Oct 2023 16:10:47 +0000 Subject: [PATCH 2/2] chore: add semicolon in the end of instruction --- src/new/wallet.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/new/wallet.js b/src/new/wallet.js index 1e74f4056..99657af27 100644 --- a/src/new/wallet.js +++ b/src/new/wallet.js @@ -228,7 +228,7 @@ class HathorWallet extends EventEmitter { **/ async getVersionData() { const versionData = await new Promise((resolve, reject)=> { - versionApi.getVersion(resolve).catch((error) => reject(error)) + versionApi.getVersion(resolve).catch((error) => reject(error)); }); return {