From 613d0ac5e7c0891ed8bd636a31203de06739636d Mon Sep 17 00:00:00 2001 From: Gabriel Levcovitz Date: Fri, 20 Oct 2023 01:37:36 -0300 Subject: [PATCH] tests: fix flaky log test --- .../test_bit_signaling_service.py | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/tests/feature_activation/test_bit_signaling_service.py b/tests/feature_activation/test_bit_signaling_service.py index b46951d8b3..f3b24e140f 100644 --- a/tests/feature_activation/test_bit_signaling_service.py +++ b/tests/feature_activation/test_bit_signaling_service.py @@ -15,7 +15,6 @@ from unittest.mock import Mock import pytest -from structlog.testing import capture_logs from hathor.feature_activation.bit_signaling_service import BitSignalingService from hathor.feature_activation.feature import Feature @@ -272,17 +271,15 @@ def get_bits_description_mock(block): support_features=support_features, not_support_features=not_support_features, ) + logger_mock = Mock() + service._log = logger_mock - with capture_logs() as logs: - service.start() + service.start() - expected_log = dict( - log_level='warning', + logger_mock.warn.assert_called_with( + 'Considering the current best block, there are signaled features outside their signaling period. ' + 'Therefore, signaling for them has no effect. Make sure you are signaling for the desired features.', best_block_height=123, best_block_hash='abc', non_signaling_features=non_signaling_features, - event='Considering the current best block, there are signaled features outside their signaling period. ' - 'Therefore, signaling for them has no effect. Make sure you are signaling for the desired features.', ) - - assert expected_log in logs