Conversation
859455c to
47951bb
Compare
47951bb to
03c9489
Compare
|
| Branch | refactor/pydantic-v2 |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result minutes (m) (Result Δ%) | Lower Boundary minutes (m) (Limit %) | Upper Boundary minutes (m) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 1.68 m(-1.91%)Baseline: 1.71 m | 1.54 m (91.75%) | 2.06 m (81.74%) |
517d775 to
7250d52
Compare
msbrogli
commented
Jan 22, 2026
msbrogli
commented
Jan 22, 2026
|
|
||
| class SideDagArgs(RunNodeArgs): | ||
| poa_signer_file: str | None | ||
| poa_signer_file: str | None = None |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1566 +/- ##
=========================================
Coverage ? 85.69%
=========================================
Files ? 441
Lines ? 33793
Branches ? 5286
=========================================
Hits ? 28959
Misses ? 3817
Partials ? 1017
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
107d6c4 to
d0ac1fe
Compare
msbrogli
commented
Jan 22, 2026
Comment on lines
+133
to
+134
| token_name: Optional[str] = None | ||
| token_symbol: Optional[str] = None |
Member
Author
There was a problem hiding this comment.
Pydantic v2 requires default value to ignore missing parameters. Should these None be included?
d0ac1fe to
84527e6
Compare
glevco
reviewed
Jan 27, 2026
eaa0320 to
cc58057
Compare
jansegre
previously approved these changes
Feb 9, 2026
glevco
requested changes
Feb 9, 2026
glevco
reviewed
Feb 9, 2026
8851d00 to
f27149c
Compare
f27149c to
42d0e73
Compare
glevco
previously approved these changes
Feb 10, 2026
jansegre
previously approved these changes
Feb 10, 2026
42d0e73 to
b88a3e9
Compare
8e4ffb1 to
caca25d
Compare
glevco
previously approved these changes
Feb 12, 2026
The merge-base changed after approval.
caca25d to
8ea0e10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR upgrades the codebase from Pydantic v1 to Pydantic v2.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged