Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CK-Editor will be invisible when installing hardocs without an internet connection #59

Closed
jurra opened this issue Dec 18, 2020 · 4 comments
Labels
bug Something isn't working urgent

Comments

@jurra
Copy link
Member

jurra commented Dec 18, 2020

Current behavior

When the app is executed offline the ckeditor will not show in the app, instead it will show this:

image

As it can be seen the editor doesnt show properly

Desired behavior

When the app is opened offline it should look like the picture below.
image

The editor should work offline as well as it works now when connected.

@jurra jurra added bug Something isn't working urgent labels Dec 18, 2020
@jurra
Copy link
Member Author

jurra commented Jan 24, 2021

This is happening because of a call being made by the MathType module,

Hey 🥇 @DNature it would be great if you could rebuild the editor without this particular module,
I am currently working on hotfix/npm-ckeditor-module you can update the packagejson and let me know when that is ready, I can then integrate it back again and review it.

Thanks in advance 😄

@DNature
Copy link
Member

DNature commented Jan 24, 2021

Okay. I will do that first thing tomorrow

@DNature
Copy link
Member

DNature commented Jan 26, 2021

  • publish new hardocs-ck-editor to npm
  • Install the latest version of hardocs-editor in the desktop app
  • Update desktop-app version
  • Test out the workflow build
  • draft a new release
  • publish the new release

@jurra
Copy link
Member Author

jurra commented Jan 29, 2021

This is solved, it implited sacrifycing the Math module. We need to keep an eye on that module development, because this is a pending issue I saw on their repository.

@jurra jurra closed this as completed Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working urgent
Projects
None yet
Development

No branches or pull requests

2 participants