MFC r342185:

iwi(4): do not leak node reference when IWI_FLAG_ASSOCIATED flag is set.
HardenedBSD · Dec 25, 2018 · bd64bae · bd64bae
1 parent 4e14cef
commit bd64bae
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/sys/dev/iwi/if_iwi.c b/sys/dev/iwi/if_iwi.c
@@ -2833,13 +2833,13 @@ iwi_auth_and_assoc(struct iwi_softc *sc, struct ieee80211vap *vap)
 
 	IWI_LOCK_ASSERT(sc);
 
-	ni = ieee80211_ref_node(vap->iv_bss);
-
 	if (sc->flags & IWI_FLAG_ASSOCIATED) {
 		DPRINTF(("Already associated\n"));
 		return (-1);
 	}
 
+	ni = ieee80211_ref_node(vap->iv_bss);
+
 	IWI_STATE_BEGIN(sc, IWI_FW_ASSOCIATING);
 	error = 0;
 	mode = 0;