Skip to content

Commit

Permalink
Disable WITH_RETPOLINE on stable/12.
Browse files Browse the repository at this point in the history
It is known that clang 7 generates broken ifunc calls when retpoline is
enabled. Since libc uses ifuncs, mark WITH_RETPOLINE as always broken
and disabled. To be removed after clang 8 MFC.

This is a direct commit to the branch.

Reported by:	many
Tested by:	Nikola Mihaylov <[email protected]>
Reviewed by:	emaste
Sponsored by:	The FreeBSD Foundation
  • Loading branch information
kostikbel committed Mar 7, 2019
1 parent 531e908 commit 4e79588
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions share/mk/src.opts.mk
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,9 @@ BROKEN_OPTIONS+=LOADER_UBOOT
BROKEN_OPTIONS+=LOADER_GELI LOADER_LUA
.endif

# clang 7.0
BROKEN_OPTIONS+=RETPOLINE

.if ${__T:Mmips64*}
# profiling won't work on MIPS64 because there is only assembly for o32
BROKEN_OPTIONS+=PROFILE
Expand Down

0 comments on commit 4e79588

Please sign in to comment.