chore(deps): revert NSec.Cryptography to stable 26.4.0#35
Conversation
signal-bridge had regressed NSec.Cryptography to the preview version 26.1.0-preview.1 while shipyard and sunfish both pin the stable 26.4.0 release. Running a preview crypto library in a security-sensitive comms mesh service is a Layer-1 prevention concern. Reverts to the stable pin to align all three repos and eliminate the preview dependency from the Bridge crypto surface. QM finding: qm-status-2026-05-22T0945Z-v4-item-6-alert-advisory.md Admiral ruling: 2026-05-22T13:00Z — revert to 26.4.0. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe centralized NuGet package manifest ChangesDependency Version Management
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
NSec.Cryptographyfrom preview26.1.0-preview.1to stable26.4.0inDirectory.Packages.props26.4.0(stable)Rationale
QM V4 #6 SDK drift recheck (
qm-status-2026-05-22T0945Z-v4-item-6-alert-advisory.md) flagged that signal-bridge had regressed NSec.Cryptography to preview while sibling repos track the stable release. NSec is the cryptographic primitives library used in the Bridge key-exchange and message-signing paths. Running preview crypto in production is a security hygiene issue regardless of API stability claims.Admiral ruling 2026-05-22T13:00Z: revert to
26.4.0. No API changes between the two versions per NuGet history; this is a version-number-only change.Change
Directory.Packages.propsline 31:26.1.0-preview.1→26.4.0Refs:
qm-status-2026-05-22T0945Z-v4-item-6-alert-advisory.mdTest plan
.NET build + testgreen on signal-bridgeNSec.CryptographyAPI compilation errors (no API changes between these versions)🤖 Generated with Claude Code
Summary by CodeRabbit