Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize build query in AbstractJoin query modifiers #260

Merged
merged 2 commits into from
Dec 4, 2020
Merged

Optimize build query in AbstractJoin query modifiers #260

merged 2 commits into from
Dec 4, 2020

Conversation

peter-gribanov
Copy link
Member

@peter-gribanov peter-gribanov commented Dec 4, 2020 •
edited
Loading

Fix #226

Upgrade

  • The AbstractJoin::getJoinType() method was removed. Use AbstractJoin::modifyJoin() method inside.

@peter-gribanov peter-gribanov self-assigned this Dec 4, 2020
@peter-gribanov peter-gribanov added this to the Release 2.0.0 milestone Dec 4, 2020
@peter-gribanov peter-gribanov mentioned this pull request Dec 4, 2020
Closed
37 tasks
@peter-gribanov peter-gribanov merged commit b094866 into Happyr:2.0 Dec 4, 2020
@peter-gribanov peter-gribanov deleted the AbstractJoin branch December 4, 2020 15:41
@peter-gribanov peter-gribanov mentioned this pull request Dec 9, 2020
Closed
@peter-gribanov peter-gribanov restored the AbstractJoin branch December 10, 2020 15:40
@peter-gribanov peter-gribanov deleted the AbstractJoin branch December 10, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@peter-gribanov peter-gribanov

Labels
BC Break feature
Projects
None yet
Milestone
Release 2.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@peter-gribanov