context in DQLContextResolver::resolveAlias() should not be empty

Author: peter-gribanov

src/DQLContextResolver.php

@@ -49,6 +49,10 @@ public static function resolveAlias(QueryBuilder $qb, string $context): string
     {
         $dqlAliasParts = explode('.', $context);
 
+        if (!$dqlAliasParts) {
+            throw new \InvalidArgumentException('You must provide context.');
+        }
+
         // any given alias can be used
         if (!self::$deadJoinsProtection) {
             return array_pop($dqlAliasParts);

src/Operand/PlatformFunction.php

@@ -71,7 +71,7 @@ final class PlatformFunction implements Operand
     /**
      * @var PlatformFunctionExecutorRegistry|null
      */
-    private static $executorRegistry = null;
+    private static $executorRegistry;
 
     /**
      * @var string
@@ -138,7 +138,7 @@ public function execute($candidate, ?string $context = null)
      */
     public static function getExecutorRegistry(): PlatformFunctionExecutorRegistry
     {
-        if (null === self::$executorRegistry) {
+        if (!self::$executorRegistry instanceof PlatformFunctionExecutorRegistry) {
             $instances = [];
 
             foreach (self::DOCTRINE_FUNCTIONS as $functionName => $class) {

tests/Operand/ValueSpec.php

@@ -15,7 +15,6 @@
 namespace tests\Happyr\DoctrineSpecification\Operand;
 
 use Doctrine\Common\Collections\ArrayCollection;
-use Doctrine\DBAL\Types\Type;
 use Doctrine\ORM\QueryBuilder;
 use Happyr\DoctrineSpecification\Operand\Operand;
 use Happyr\DoctrineSpecification\Operand\Value;
@@ -59,7 +58,7 @@ public function it_is_transformable(QueryBuilder $qb, ArrayCollection $parameter
 
     public function it_is_transformable_dbal_type(QueryBuilder $qb, ArrayCollection $parameters): void
     {
-        $valueType = Type::DATE;
+        $valueType = 'date';
         $this->beConstructedWith($this->value, $valueType);
 
         $qb->getParameters()->willReturn($parameters);

tests/Operand/ValuesSpec.php

@@ -15,7 +15,6 @@
 namespace tests\Happyr\DoctrineSpecification\Operand;
 
 use Doctrine\Common\Collections\ArrayCollection;
-use Doctrine\DBAL\Types\Type;
 use Doctrine\ORM\QueryBuilder;
 use Happyr\DoctrineSpecification\Operand\Operand;
 use Happyr\DoctrineSpecification\Operand\Values;
@@ -59,7 +58,7 @@ public function it_is_transformable(QueryBuilder $qb, ArrayCollection $parameter
 
     public function it_is_transformable_dbal_type(QueryBuilder $qb, ArrayCollection $parameters): void
     {
-        $valueType = Type::DATE;
+        $valueType = 'date';
         $this->beConstructedWith($this->values, $valueType);
 
         $qb->getParameters()->willReturn($parameters);