You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It doesn't seem to be, and is stopping me from compiling a netcore2.2 app
EDIT: I see that the LoggerFactory.Create method is indeed being used, so technically that makes a dependency. Can we find a different way so that we can rely on 2.2 versions of the logger?
The text was updated successfully, but these errors were encountered:
Yes sure! I will probably switch to a better logger (probs Serilog). I'm going to be a little busy for a while yet, so if you want to go ahead and remove the dependency (I don't think I make extensive use of the logger) and PR it then that would be cool :)
I instead encourage to further embrace Microsoft's logger interface (abstract interface only, Serilog underneath is a fine choice) - I'm sure we can make it gracefully live in your environment ! If I have time to do a PR definitely will. I tried removing the dependency, but need to fiddle with the factory more.
Also, separately, hit an issue with Client.Keys, wasn't present so wouldnt compile -- any guidance there?
It doesn't seem to be, and is stopping me from compiling a netcore2.2 app
EDIT: I see that the LoggerFactory.Create method is indeed being used, so technically that makes a dependency. Can we find a different way so that we can rely on 2.2 versions of the logger?
The text was updated successfully, but these errors were encountered: