Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Microsoft.Extensions.Logging 3.0.0-preview.19074.2 necessary? #7

Open
malachib opened this issue Mar 27, 2019 · 3 comments
Open

Comments

@malachib
Copy link

malachib commented Mar 27, 2019

It doesn't seem to be, and is stopping me from compiling a netcore2.2 app

EDIT: I see that the LoggerFactory.Create method is indeed being used, so technically that makes a dependency. Can we find a different way so that we can rely on 2.2 versions of the logger?

@Half-Shot
Copy link
Owner

Yes sure! I will probably switch to a better logger (probs Serilog). I'm going to be a little busy for a while yet, so if you want to go ahead and remove the dependency (I don't think I make extensive use of the logger) and PR it then that would be cool :)

@malachib
Copy link
Author

malachib commented Mar 27, 2019

I instead encourage to further embrace Microsoft's logger interface (abstract interface only, Serilog underneath is a fine choice) - I'm sure we can make it gracefully live in your environment ! If I have time to do a PR definitely will. I tried removing the dependency, but need to fiddle with the factory more.

Also, separately, hit an issue with Client.Keys, wasn't present so wouldnt compile -- any guidance there?

@Half-Shot
Copy link
Owner

Yeah, it was missing some stuff, commited those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants