Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix links made with annotations #93

Merged
merged 2 commits into from
Jul 22, 2019
Merged

Fix links made with annotations #93

merged 2 commits into from
Jul 22, 2019

Conversation

KapiX
Copy link
Member

@KapiX KapiX commented Jul 19, 2019

@KapiX
Copy link
Member Author

KapiX commented Jul 19, 2019

Please test with gcc2 before merging, and a few PDF files (I have tested only one).

@humdingerb
Copy link
Member

Compiles and runs fine with gcc2. All PDFs that show the pin-problem display perfectly pin-less with these changes. Well done!!

waddlesplash
waddlesplash reviewed Jul 20, 2019
View reviewed changes
bepdf/beos/Annotation.cpp Outdated
mLinkAction = LinkAction::parseAction(&obj/*, baseURI*/);
}
}
obj.free();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of the file is in tabs, but this is in spaces. Koder bug? :p

Copy link
Member Author

@KapiX KapiX Jul 20, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I do not see .editorconfig in this repo. Where would the bug be? :)
  2. I was more occupied reverting all the removed trailing whitespace to actually notice that indentation is inconsistent. ;)
  3. This is copied verbatim from XPDF.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, can't Koder auto-detect the use of tabs in most source files? I thought it did...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It overrides settings only if there is .editorconfig in the repo (and that has a few bugs). There is no auto-detection.

@KapiX KapiX merged commit 51ce146 into HaikuArchives:master Jul 22, 2019
@humdingerb humdingerb mentioned this pull request Dec 2, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waddlesplash waddlesplash waddlesplash left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Links show an overlayed big pin icon
3 participants
@KapiX @humdingerb @waddlesplash