From 033ae656654fad2b1147fd189977e1657dcd891b Mon Sep 17 00:00:00 2001 From: Pierre Baize Date: Fri, 4 Oct 2019 10:44:04 -0400 Subject: [PATCH 1/2] rename --- src/browser/api/browser_view.ts | 4 ++-- src/browser/remote_subscriptions.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/browser/api/browser_view.ts b/src/browser/api/browser_view.ts index 76c35ed4a..a4bae42c0 100644 --- a/src/browser/api/browser_view.ts +++ b/src/browser/api/browser_view.ts @@ -4,7 +4,7 @@ import { addBrowserView, getBrowserViewByIdentity, getWindowByUuidName, OfView, removeBrowserView, updateViewTarget, getInfoByUuidFrame } from '../core_state'; -import { BrowserViewCreationOptions } from '../../../js-adapter/src/api/browserview/browserview'; +import { ViewCreationOptions } from '../../../js-adapter/src/api/view/view'; import convertOptions = require('../convert_options'); import { getInfo as getWebContentsInfo, setIframeHandlers, hookWebContentsEvents} from './webcontents'; import of_events from '../of_events'; @@ -16,7 +16,7 @@ import { downloadScripts } from '../preload_scripts'; const windowCloseListenerMap: WeakMap void>> = new WeakMap(); -export type BrowserViewOpts = WebOptions & BrowserViewCreationOptions; +export type BrowserViewOpts = WebOptions & ViewCreationOptions; export async function create(options: BrowserViewOpts) { // checking if the name-uuid combination is already in use const { uuid, name } = options; diff --git a/src/browser/remote_subscriptions.ts b/src/browser/remote_subscriptions.ts index 4e88936d4..4b91f411b 100644 --- a/src/browser/remote_subscriptions.ts +++ b/src/browser/remote_subscriptions.ts @@ -343,7 +343,7 @@ async function getClassEventEmitter(subscription: RemoteSubscription, runtime: P classEventEmitter = await runtime.fin.Window.wrap({uuid, name}); break; case 'view': - classEventEmitter = runtime.fin.BrowserView.wrapSync({uuid, name}); + classEventEmitter = runtime.fin.View.wrapSync({uuid, name}); } return classEventEmitter; From 3d8a9bf23c170644f2f4ba63d60100459b8a9b8e Mon Sep 17 00:00:00 2001 From: Pierre Baize Date: Mon, 7 Oct 2019 16:57:19 -0400 Subject: [PATCH 2/2] empty