Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Local Development' part of the README file needs to be modified. #4362

Closed
DigitalBard opened this issue Nov 8, 2023 · 1 comment
Closed

Comments

@DigitalBard
Copy link
Contributor

DigitalBard commented Nov 8, 2023

Describe the bug
When I followed the steps of the "Local Development" part of README file, I got an error like below:
error

That's because when I did yarn build-dev, the dist directory was incomplete.
dist

And there was another warning like this:
1

But when I followed the 'Getting set up' part of 'CONTRIBUTING.md' file, everything was okay.
distrig

To Reproduce
Steps to reproduce the behavior:

  1. Clone the project by "git clone".
  2. yarn install
  3. yarn build-dev
  4. yarn start

Expected behavior
So, I recommend to modify the 'Local Development' part of the 'README file' like 'Getting set up' part of 'CONTRIBUTING.md' file,
or rewrite simply like "Please refer to 'CONTRIBUTING.md' file."

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome
@yuki0410-dev
Copy link
Contributor

@DigitalBard (cc. @martijnrusschen )
It looks like the PRs have already been merged, are there any other issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants