Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the preferred order of transforms #3

Open
lencioni opened this issue Feb 26, 2016 · 1 comment
Open

What is the preferred order of transforms #3

lencioni opened this issue Feb 26, 2016 · 1 comment

Comments

@lencioni
Copy link

I noticed a TODO in the readme: TODO: define preferred order of transforms. What do you see is the preferred order of the transforms?

@RSO
Copy link
Contributor

RSO commented Mar 2, 2016

Hi there! Sorry for not getting back to you sooner, but we actually moved forward with the conversion this week, so I had a lot on my mind :)

This is the order we ran the transforms in on our own codebase:

  1. implicit-var-declarator
  2. backbone-classes
  3. default-params
  4. fat-arrow
  5. index-of
  6. object-literal
  7. JSX (https://github.com/reactjs/react-codemod/blob/master/transforms/create-element-to-jsx.js)

If you are interested in running these transforms yourself please let me know. There's a lot of documentation missing, and I guess that it would be easier for you if would know a bit more about the codebase that you're thinking of converting (as you might see we didn't run all transforms on our own codebase yet, because some turned out to be problematic).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants