Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement linters for Python, CSS, JS, JSON and YML files #938

Closed
tunetheweb opened this issue Jun 29, 2020 · 2 comments · Fixed by #939
Closed

Implement linters for Python, CSS, JS, JSON and YML files #938

tunetheweb opened this issue Jun 29, 2020 · 2 comments · Fixed by #939
Assignees
Labels
development Building the Almanac tech stack

Comments

@tunetheweb
Copy link
Member

As discussed in #933 (comment) GitHub has a superlinter which will help to find typos and ensure a consistent coding style.

This can run through a GitHub action when a pull request is submitted so the requester gets quick feedback and can correct their code.

Downsides:

  • Linting can lead to a large clean up when applying to old code
  • It can enforce overly strict rules that annoy more than help. Key is to tune the rules to those useful for us. And change them if we want.
@tunetheweb tunetheweb added the development Building the Almanac tech stack label Jun 29, 2020
@tunetheweb tunetheweb added this to the 2020 Platform Development milestone Jun 29, 2020
@tunetheweb tunetheweb self-assigned this Jun 29, 2020
@ibnesayeed
Copy link
Contributor

I can review the code once a PR is up.

@tunetheweb
Copy link
Member Author

Was hoping you would! 😀 Coming right up!

This was referenced Jun 29, 2020
@rviscomi rviscomi mentioned this issue Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Building the Almanac tech stack
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants