Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comma separating two contributors #1247

Closed
rviscomi opened this issue Aug 24, 2020 · 3 comments · Fixed by #1266
Closed

Comma separating two contributors #1247

rviscomi opened this issue Aug 24, 2020 · 3 comments · Fixed by #1266
Labels
bug Something isn't working development Building the Almanac tech stack good first issue Good for newcomers

Comments

@rviscomi
Copy link
Member

rviscomi commented Aug 24, 2020

On chapter pages like Media, when there are two authors or reviewers, the contributor names are separated by ", and".

I would only expect the names to be separated by "and". For example:

A
A and B
A, B, and C

image

This affects both the chapter pages and the ebook.

@rviscomi rviscomi added bug Something isn't working good first issue Good for newcomers development Building the Almanac tech stack labels Aug 24, 2020
@rviscomi rviscomi added this to the 2020 Platform Development milestone Aug 24, 2020
@tunetheweb
Copy link
Member

Presume you still want an oxford comma for 3 or more names?

@rviscomi
Copy link
Member Author

Yes, clarified the desired behavior.

@tunetheweb
Copy link
Member

Added another clarification that this impacts both chapter and ebook.

A bit of Jinja2 templating dev if any of the @HTTPArchive/developers want to take a stab at it? Good one for learning how our templating works and happy to give any guidance here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working development Building the Almanac tech stack good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants