-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contributor profile pages #1195
Comments
Good idea. I’ve been thinking our contributor page is a bit light and think we should have links back to chapters they worked on. Saying someone was an author isn’t much use, without saying what chapter(s) they authored on! However I still think it’s good to highlight the contributors for each year. To say we 96 contributors to 2019 edition (and who they were), and that there were 116 contributors for 2020 (and who they were). So I’d probably keep the contributors page as it is now as well and link to the individual profile pages from it. Maybe also have an But definitely agree we should avoid repeating data across years. Not sure individual files per contributor are a great idea - could slow things down to read many of them either at start up or dynamically when a page is requested, e.g. if we keep the contributors page, or in chapters with lots of contributors - unless we have name as well as if in the
With the linting we have, the chance of bad config getting I there is very low, so think maintaining in combined files like this is fine. Maybe if we start to get a lot of extra meta-data to build full profile pages, so we get concerned about size of JSON file, then that can go in individual files and |
+1 let's keep the existing
Either way. With contributor-specific files, it's easier to maintain. At deploy time we can run a script to bundle them up into a single config, or "hydrate" the year-specific config files with the perennial metadata. Having files for each contributor enables us to render the profile pages based directly on "file_exists" checks rather than loading all contributor data and testing whether a contributor key exists. Tradeoffs with each approach, but I'll defer to you on implementation. |
I started looking into this and I'm feeling more enthusiastic about going in this direction. I like the idea of a page where contributors could list all of their multi-year contributions across the entire project. A few concrete suggestions:
|
@HTTPArchive/developers is anyone interested in building the infrastructure and UX for contributor profile pages? |
I can pick this up |
Made a version of the contributors' page for desktop. Mobile incoming - https://www.figma.com/file/Q9Zu4uLTtzLQT1TqVG4OiS/Web-Almanac?node-id=0%3A1 |
Looks great thanks @GeekBoySupreme! @tunetheweb any general feedback? I'm also curious how you feel about developers/designers not having any specific "contributions" to list and if there's anything we can do to mitigate that. Any other feedback from @HTTPArchive/designers? Miscellaneous feedback: If someone contributes to the CSS chapter all three years in a row, would they have the 2019, 2020, and 2021 labels under the CSS chapter, or would it be listed three times? I think we can remove the next/previous buttons since I expect most users to directly access contributor pages rather than browse through them. Could we incorporate the same box-shadow and rounded corners style here as on the Contributors page for a bit of visual continuity? I think it could work as a wrapper around the bio area at the top. Similar to the floating buttons in #1617/#2196 should we have an "Edit this page" floating button so anyone could quickly submit a PR to change a contributor's metadata? Similarly, if we support translations for everyone's bio, should we have a "Translate this page" button? |
I like how clean it looks :) What are the 2 images on the page (e.g. the tent)? |
Initial feedback are that it looks great! This is definitely doable. Should we make the contributions more like “Author 2021 CSS” that clicks through to those chapters? That would handle multiple years, different roles in each year and also different roles in same year (e.g. I might have “Author 2021 CSS”, “Analyst 2021 CSS” and “Author 2020 CSS” buttons - though first two would both link to the same chapter). Not sure we need the chapter paragraph. It does looks nice but difficult to fit with the above suggestion and shouldn’t this page be more about the contributor than the chapter? For Development maybe they click through to GitHub commits. For design more difficult but maybe GitHub issue comments? Though previous years designers have not communicated via GitHub. If not GitHub profile then not link. Should that be greyed our colour? I’d probably remove the roles from the top section. It’s repetitive of the buttons below and think this top bit should be about the contributors profile and social buttons, and the bottom section about their Web Almanac contributions. Will think some more… |
Thanks for the feedback folks. @rviscomi for same roles across multiple years on same chapters, I would stack the years against the role name, that would prevent scrolling a lot. The segmentation becomes - Same chapter, multiple years. Would post iterations for these. Plus, we can simply replace the next and prev buttons with Edit Page and Translate. @shantsis the images are representative of badges that @rviscomi had proposed we might add. They're just placeholders for now, would design the badges sometime else. @tunetheweb agree with your suggestions. |
Revisiting this old feature request. @GeekBoySupreme do you have any time this month to get this page over the finish line? I'd love to be able to launch the 2021 edition with contributor profile pages and we're so close! |
Definitely yes. |
This FR came up recently. I'm still very interested to see this implemented, even if we just start with splitting out contributor configs into their own files. I'm also open to revisiting whether to use JSON or YAML for the config files, the latter having the advantage of being able to use inline comments. |
Hey :) I just made a draft here for the desktop and mobile versions. Can you check and give me feedback if it is something you are looking for? https://xd.adobe.com/view/fb42d3df-2310-4da6-8050-73f14184b350-ae11/ |
Sorry for the delay, I'm traveling for the perfnow conference this week. I'll be sure to turn around my feedback to you next week! |
Sorry again for the delay @yuseyhan, but thank you for taking the time to work on this design. I really like the direction and I have a few notes to refine it a bit more. Right now the chapter metadata is very prominent. What if we collapsed that in a way that lets us pack more contributions onto the screen, like a grid view? So we would only show the top-level info, like the chapter title. Maybe it could be interactive in a way that expands the card to show more of that metadata, like a modal or something. Also, rather than grouping by year, what if we group by chapter? So for example, we could have something like a "card" for a chapter, and the contents of the card include the chapter title and all the ways the person contributed to it over the years. We'd need a way to distinguish between year-specific contributions, for example in 2022 I was an author of the Performance chapter, but in 2021 I was only a reviewer. Not totally sure of the best way to do that, open to ideas. I'd also like to find a way to keep the idea of having "collectable" badges on a contributor's profile page. Like, if I've ever been an author, I earn the "Author" badge. If I contributed in any way to the 2022 edition, I earn the "2022" badge. Each one would need its own illustration but we can use placeholders or text for now. Anyway, thank you again for working on this. I'd love to hear your ideas. |
I'd like to pitch an idea for discussion: year-agnostic profile pages for each contributor.
For those who contribute to multiple annual editions, some of their metadata is duplicated across the config files, like name and social links. Authors also have bios in the year's base template. It may be useful to deduplicate the metadata about a contributor that doesn't change over time, like their name, social links, and bio, from the metadata that is year-specific, like the teams and chapters.
So for example, I could add basic metadata about myself to
/src/config/contributors/rviscomi.json
(or.yaml
):Then in
2019.json
and2020.json
I only need to map my contributor IDrviscomi
to the teams I contributed to those years. We could also get info about which chapters I contributed to from the YAML in the chapter markdown files.All of this contributor info could be made publicly available via endpoints like
/<lang>/contributors/<id>
, eghttps://almanac.httparchive.org/en/contributors/rviscomi
. I imagine the page being somewhat similar to dev.to/rick_viscomi:Right now only authors have bios and they're only visible on the chapter pages. This proposal would enable all contributors to have bios on their personal profile pages and it'd be easier to go back through all of their contributions over the years.
Curious to hear if this is something contributors want, whether there are any unforeseen technical complexities, or if there are any other ideas for ways we could utilize a page like this to showcase contributors' work.
The text was updated successfully, but these errors were encountered: