Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No clickable deeplink for CDN figure 2 #1154

Closed
rviscomi opened this issue Aug 4, 2020 · 1 comment · Fixed by #1156
Closed

No clickable deeplink for CDN figure 2 #1154

rviscomi opened this issue Aug 4, 2020 · 1 comment · Fixed by #1156
Labels
bug Something isn't working development Building the Almanac tech stack good first issue Good for newcomers
Milestone
2019 Backlog

Comments

@rviscomi
Copy link
Member

rviscomi commented Aug 4, 2020

See https://almanac.httparchive.org/en/2019/cdn#fig-2

image

I'd expect the text "Figure 2" to link to the URL above, but there is no link. Is this because it is suffixed with : rather than .? Should be an easy fix.
@rviscomi rviscomi added bug Something isn't working good first issue Good for newcomers development Building the Almanac tech stack labels Aug 4, 2020
@rviscomi rviscomi added this to the 2019 Backlog milestone Aug 4, 2020
@SaptakS SaptakS mentioned this issue Aug 4, 2020
Merged
@tunetheweb
Copy link
Member

Hopefully #1138 will be the longer term fix to prevent this from happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working development Building the Almanac tech stack good first issue Good for newcomers
Projects
None yet
Milestone
2019 Backlog
Development

Successfully merging a pull request may close this issue.

Fixes deeplinks for figures with ":" instead of "." SaptakS/almanac.httparchive.org
2 participants
@rviscomi @tunetheweb