Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn resolution warnings #4742

Open
hbruch opened this issue Feb 13, 2023 · 4 comments
Open

yarn resolution warnings #4742

hbruch opened this issue Feb 13, 2023 · 4 comments

Comments

@hbruch
Copy link
Contributor

hbruch commented Feb 13, 2023

yarn run setup currently reports various warnings in the resolution step.
They can be grouped in the following categories:

  1. missing peerDependencies (YN0002) in digitransit-ui or digitransit-ui-components
  2. missing peerDependencies (YN0002) in hsl components
  3. missing peerDependencies (YN0002) in third party components
  4. not-satisfying versions provided (YN0060)

I suggest the following actions to resolve these warnings:

  1. fix declared peerDependencies in digitransit-ui or digitransit-ui-components
  2. fix declared peerDependencies in hsl-fi packages and upgrade digitransit-ui to updated versions
  3. As temporary fix, add missing peerDependencies as packageExtensions to .yarnrc.yml and mid-term upgrade concerned packages (assuming they are fixed in the meantime, otherwise suggest fixes there)
  4. check and correct versions. IMHO most clashes are caused by fixed versions in package.json, where rather ranges should be specified.
@hbruch
Copy link
Contributor Author

hbruch commented Feb 13, 2023

I'll provide a PR for 1., 3. and 4. @vesameskanen could anyone from HSL address the hsl-fi changes? Otherwise I'd add (at least temporarilly) packageExtensions.

@vesameskanen
Copy link
Member

I can try to fix hsl.fi related warnings.

@vesameskanen
Copy link
Member

I wonder what is the proper fix for workspace related warnings. For example, all sub components of digitransit-component library give a warning that digitransit-component does not provide i18next, but I guess that is intentional. The mentioned library is provided by the root package.json.

@hbruch
Copy link
Contributor Author

hbruch commented Feb 15, 2023

peerDeependencies need to be defined not only on the top-level project, but by it's components as well. #4751 fixes these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants