New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change startTime and endTime for Attendance entity to type string #127

Closed

thai-truong opened this issue Oct 17, 2020 · 1 comment · Fixed by #145

Assignees

Contributor

thai-truong commented Oct 17, 2020

Right now it's type Date, which is incorrect because TypeORM converts those startTime and endTime to ISO timestamps already

thai-truong self-assigned this

thai-truong linked a pull request

that will close this issue

Fix attendance time issue, again #145

Merged

Contributor Author

thai-truong commented Dec 19, 2020

Actually type Date is correct because of how jank typeorm is with datetime types. Resolved

thai-truong closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment