Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convergence criteria for optimizers #390

Open
mohit-surana opened this issue Apr 30, 2018 · 1 comment
Open

Convergence criteria for optimizers #390

mohit-surana opened this issue Apr 30, 2018 · 1 comment

Comments

@mohit-surana
Copy link

Many optimization frameworks provide an optional argument - tol or tolerance that lets one stop optimization if the function, gradient or parameter does not change much for a given iteration. This is used in conjunction with a parameter max_iter for a hard upper bound on the number of iterations the optimizer is to be run for.

The optimizers in the autograd package currently do not support this.

  1. Are there plans of implementing this functionality?
  2. If not, would it be a good idea for me to go ahead and implement this or do you feel that the increased computational complexity isn't worth it?

Thanks and great work on the package. Just used this for an assignment and it is really powerful!
A more navigable documentation would be great though.

@mohit-surana
Copy link
Author

Two ways that I thought this could be done are:

  • tol as a user passed argument. Actual computation and checking happens on each iteration
    This is slower but provides a richer interface to the user
  • Return value of the callback function is checked as an exit criteria
    Existing code is unaffected. Library users are free to implement any kind of convergence criteria

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant