Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADR]: Front-end Code Quality Tools #102

Closed
12 tasks
Tracked by #50
widal001 opened this issue Jun 28, 2023 · 1 comment · Fixed by #190
Closed
12 tasks
Tracked by #50

[ADR]: Front-end Code Quality Tools #102

widal001 opened this issue Jun 28, 2023 · 1 comment · Fixed by #190
Assignees
@daphnegold
Labels
docs: adr Architecture decision record ticket project: grants.gov Grants.gov Modernization tickets
Milestone
Developer Tools

Comments

@widal001
Copy link
Collaborator

widal001 commented Jun 28, 2023 •
edited
Loading

Description

Evaluate and select libraries to enforce the following standards within the frontend codebase:

  • Dependency management (e.g. conflicts, updates, etc.)
  • Code Linting
  • Auto-formatting
  • Type checking
  • Checking for vulnerable dependencies
  • Checking for open source licenses

Definition of Done

  • The approvers for this decision have been identified (ideally before work on the ADR starts)
  • The ADR is created and stored in documentation/decisions/adr with status "Accepted"
  • The ADR has been reviewed and approved by the approvers listed above
  • The ADR satisfies requirements that are outlined in the ADR template
  • Any follow-up tickets have been created (if necessary)
  • The ADR covers each of the following tools:
    • Dependency management
    • Code linting
    • Auto-formatting
    • Type checking
    • Dependency vulnerability checking
    • License checking
@widal001 widal001 added the docs: adr Architecture decision record ticket label Jun 28, 2023
@widal001 widal001 added this to the Frontend Planning milestone Jun 28, 2023
@widal001 widal001 changed the title ADR: Front-end Code Quality Tools ADR: Front-end Codebase Setup Jun 28, 2023
@widal001 widal001 changed the title ADR: Front-end Codebase Setup ADR: Front-end Code Quality Tools Jun 28, 2023
@widal001 widal001 modified the milestones: Frontend Planning, Static Site Launch with NOFO Content Jun 29, 2023
@widal001 widal001 moved this from Backlog to Prioritized in Simpler.Grants.gov Product Backlog Jun 30, 2023
@widal001 widal001 mentioned this issue Jun 30, 2023
Closed
17 tasks
@widal001 widal001 mentioned this issue Jul 3, 2023
Closed
13 tasks
@daphnegold daphnegold self-assigned this Jul 7, 2023
@daphnegold
Copy link
Contributor

Similar to back-end separation of concerns, suggesting we move testing and coverage tooling to a separate ADR

@daphnegold daphnegold moved this from Sprint Backlog to In Progress in Simpler.Grants.gov Product Backlog Jul 11, 2023
@daphnegold daphnegold mentioned this issue Jul 11, 2023
Merged
@daphnegold daphnegold moved this from In Progress to In Review in Simpler.Grants.gov Product Backlog Jul 13, 2023
@widal001 widal001 added the project: grants.gov Grants.gov Modernization tickets label Jul 14, 2023
@SammySteiner SammySteiner mentioned this issue Jul 19, 2023
Open
3 tasks
@daphnegold daphnegold mentioned this issue Jul 25, 2023
Open
5 tasks
@sumiat sumiat mentioned this issue Jul 25, 2023
Closed
8 tasks
@daphnegold daphnegold mentioned this issue Jul 25, 2023
Open
2 tasks
@widal001 widal001 changed the title ADR: Front-end Code Quality Tools [ADR]: Front-end Code Quality Tools Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daphnegold daphnegold

Labels
docs: adr Architecture decision record ticket project: grants.gov Grants.gov Modernization tickets
Projects
Simpler.Grants.gov Product Backlog
Archived in project
Milestone
Developer Tools
Development

Successfully merging a pull request may close this issue.

ADR for front-end code quality tools HHS/simpler-grants-gov
2 participants
@daphnegold @widal001