Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 5.8 Shift #605

Merged
merged 22 commits into from
Mar 6, 2019
Merged

Laravel 5.8 Shift #605

merged 22 commits into from
Mar 6, 2019

Conversation

HDVinnie
Copy link
Collaborator

This pull request includes the changes for upgrading to Laravel 5.8. Feel free to commit any additional changes to the shift-12246 branch.

Before merging, you should:

  • Checkout the shift-12246 branch
  • Review all pull request comments for additional changes
  • Update your dependencies for Laravel 5.8
  • Run composer update (if the pre-scripts fail, add --no-scripts)
  • Thoroughly test your application

If you want help with your upgrade, check out the Shift Human Services or join the Shifty Coders Slack room to get answers to all your Laravel questions.

To conform with PSR-16 Laravel 5.8 changed the cache expiration time from minutes to seconds. If you were passing an integer, Shift converted this to its integer equivalent in seconds. If you were passing a "minutes" variable, Shift converted this to the relative date time equivalent for readability.
@HDVinnie
Copy link
Collaborator Author

HDVinnie commented Feb 26, 2019

❌ Shift could not upgrade the following configuration files since they differed from the default Laravel version. You will need to compare these configuration files against the Laravel 5.8 configuration files and merge any changes:

  • config/app.php
  • config/cache.php
  • config/database.php
  • config/logging.php
  • config/mail.php
  • config/queue.php
  • config/services.php
  • config/session.php
  • config/view.php

@HDVinnie
Copy link
Collaborator Author

⚠️ Laravel 5.8 introduced a set of AWS environment variables to help consolidate configuring AWS services. You should rename the following environment variables to their new AWS names.

  • SQS_KEY to AWS_ACCESS_KEY_ID
  • SQS_SECRET to AWS_SECRET_ACCESS_KEY
  • SQS_REGION to AWS_REGION
  • SES_KEY to AWS_ACCESS_KEY_ID
  • SES_SECRET to AWS_SECRET_ACCESS_KEY
  • SES_REGION to AWS_REGION

@HDVinnie
Copy link
Collaborator Author

⚠️ Shift could not upgrade the RedirectIfAuthenticated middleware. Laravel 5.8 now passes an array of guards as the third argument. You will need to compare the default Laravel 5.8 versions and merge any changes.

@HDVinnie
Copy link
Collaborator Author

❌ Laravel 5.8 has a dependency for php of ^7.1.3. You have a modified dependency for php in your composer.json. You should review your dependency and ensure it meets the new version requirement.

@HDVinnie
Copy link
Collaborator Author

❌ Laravel 5.8 has a development dependency for mockery/mockery of ^1.0. You have a modified dependency for mockery/mockery in your composer.json. You should review your dependency and ensure it meets the new version requirement.

@HDVinnie
Copy link
Collaborator Author

❌ Laravel 5.8 has a development dependency for nunomaduro/collision of ^2.0. You have a modified dependency for nunomaduro/collision in your composer.json. You should review your dependency and ensure it meets the new version requirement.

@HDVinnie
Copy link
Collaborator Author

❌ Laravel 5.8 has a development dependency for phpunit/phpunit of ^7.5. You have a modified dependency for phpunit/phpunit in your composer.json. You should review your dependency and ensure it meets the new version requirement.

@HDVinnie
Copy link
Collaborator Author

⚠️ Laravel 5.8 changed the TTL for the Cache methods from minutes to seconds. Shift automated this change, however, given the dynamic nature of PHP your application may still contain some TTL arguments in minutes.

While your application will still run, this would lead to early expiration for your cached values. You should review your caching calls to ensure the TTL was upgraded to seconds.

@HDVinnie
Copy link
Collaborator Author

🎉 Congratulations, you're now running the latest version of Laravel. You can now use some of the micro Shifts to ensure your app is fully upgraded and following the Laravel recommended and community practices.

  • Laravel Linter analyzes your codebase for potential opportunities to do things "The Laravel Way".
  • Laravel Fixer automates many of the suggestions found by the Analyzer and Linter.
  • Upgrade Checker ensures your application is fully upgraded by detecting any outdated code.

@HDVinnie
Copy link
Collaborator Author

HDVinnie commented Mar 6, 2019

This PR is pending. Waiting for a upstream PR to be merged.

Elhebert/laravel-sri#24

@HDVinnie HDVinnie merged commit 970ddfd into master Mar 6, 2019
@HDVinnie HDVinnie deleted the shift-12246 branch March 6, 2019 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants