-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel 5.8 Shift #605
Laravel 5.8 Shift #605
Conversation
To conform with PSR-16 Laravel 5.8 changed the cache expiration time from minutes to seconds. If you were passing an integer, Shift converted this to its integer equivalent in seconds. If you were passing a "minutes" variable, Shift converted this to the relative date time equivalent for readability.
❌ Shift could not upgrade the following configuration files since they differed from the default Laravel version. You will need to compare these configuration files against the Laravel 5.8 configuration files and merge any changes:
|
|
|
❌ Laravel 5.8 has a dependency for |
❌ Laravel 5.8 has a development dependency for |
❌ Laravel 5.8 has a development dependency for |
❌ Laravel 5.8 has a development dependency for |
While your application will still run, this would lead to early expiration for your cached values. You should review your caching calls to ensure the TTL was upgraded to seconds. |
🎉 Congratulations, you're now running the latest version of Laravel. You can now use some of the micro Shifts to ensure your app is fully upgraded and following the Laravel recommended and community practices.
|
Apply fixes from StyleCI
Apply fixes from StyleCI
Apply fixes from StyleCI
This PR is pending. Waiting for a upstream PR to be merged. |
This pull request includes the changes for upgrading to Laravel 5.8. Feel free to commit any additional changes to the
shift-12246
branch.Before merging, you should:
shift-12246
branchcomposer update
(if the pre-scripts fail, add--no-scripts
)If you want help with your upgrade, check out the Shift Human Services or join the Shifty Coders Slack room to get answers to all your Laravel questions.